udp: slightly refactor udp_append()
ClosedPublic
Actions

Authored by glebius on Aug 26 2025, 5:09 PM.

Details

Reviewers

markj
kp
tuexen

Group Reviewers

transport

Commits

rGd0f4c558f920: udp: slightly refactor udp_append()

Summary

Make it bool. Reword the comment, add note that mbuf is always consumed.
In case tunnel consumed the mbuf, don't INP_RUNLOCK(), behave just like
all the other normal exits from the function.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66546
Build 63429: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 26 2025, 5:09 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 26 2025, 5:09 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Aug 26 2025, 5:09 PM

Harbormaster completed remote builds in B66546: Diff 161006.Aug 26 2025, 5:09 PM

glebius added a parent revision: D52170: udp: don't leak mbuf if tunnel didn't consume and inpcb is gone.Aug 26 2025, 5:09 PM

Michael had fixed this bug at Netflix several years ago, but we forgot to upstream that. Merging in FreeBSD, I found our code nicer, especially no extra INP_RUNLOCK(). Converting to bool and comment editing is my today's additions.

markj accepted this revision.Aug 26 2025, 5:28 PM

kp accepted this revision.Aug 26 2025, 6:11 PM

tuexen accepted this revision.Aug 26 2025, 6:44 PM

This revision is now accepted and ready to land.Aug 26 2025, 6:44 PM

Closed by commit rGd0f4c558f920: udp: slightly refactor udp_append() (authored by glebius). · Explain WhySep 1 2025, 4:34 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGd0f4c558f920: udp: slightly refactor udp_append().