Page MenuHomeFreeBSD
Differential D51910

libsa/zfs: ignore labels with zero txg
ClosedPublic
Actions

Authored by glebius on Aug 15 2025, 5:42 AM.
Tags
None
Referenced Files
F176263742: D51910.id.diff
Sat, Oct 17, 11:58 AM
F176256328: D51910.id160384.diff
Sat, Oct 17, 9:58 AM
F176254417: D51910.id160672.diff
Sat, Oct 17, 9:27 AM
F176251959: D51910.diff
Sat, Oct 17, 8:53 AM
Unknown Object (File)
Mon, Oct 12, 2:06 PM
Unknown Object (File)
Mon, Oct 12, 1:35 PM
Unknown Object (File)
Sat, Oct 10, 10:38 PM
Unknown Object (File)
Sat, Oct 10, 12:43 AM
View All Files
Subscribers
dab
delphij

Details

Reviewers
mav
imp
tsoome
manu
Commits
rGde055556a0d1: libsa/zfs: ignore labels with zero txg
Summary

Zero txg means this vdev has been correctly removed from the pool. For
reference see module/zfs/vdev_removal.c in OpenZFS. It calls
vdev_label_init(vd, 0, VDEV_LABEL_REMOVE), and second argument there is
the txg to write.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66253
Build 63136: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 15 2025, 5:42 AM
Herald added a reviewer: manu. · View Herald TranscriptAug 15 2025, 5:42 AM
Herald added subscribers: dab, delphij. · View Herald Transcript
Harbormaster completed remote builds in B66253: Diff 160384.Aug 15 2025, 5:42 AM
glebius requested review of this revision.Aug 15 2025, 5:42 AM
glebius added a parent revision: D51909: libsa/zfs: remove unused variable.
glebius added a child revision: D51911: libsa/zfs: simplify vdev_find_previous().
imp accepted this revision.Aug 15 2025, 9:27 PM
This revision is now accepted and ready to land.Aug 15 2025, 9:27 PM
mav accepted this revision.Aug 18 2025, 2:51 PM

Searching for ZPOOL_CONFIG_POOL_TXG in OpenZFS I indeed see plenty of similar txg == 0 checks.

tsoome accepted this revision.Aug 18 2025, 4:04 PM

thanks!

Closed by commit rGde055556a0d1: libsa/zfs: ignore labels with zero txg (authored by glebius). · Explain WhyAug 20 2025, 2:54 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGde055556a0d1: libsa/zfs: ignore labels with zero txg.

Revision Contents
Changeset List

PathSize
stand/
libsa/
zfs/
3 lines

Diff 160384

View Options

stand/libsa/zfs/zfsimpl.c

Loading...