Page MenuHomeFreeBSD

gif.4: Mention that gif(4) can tunnel Ethernet traffic
AcceptedPublic

Authored by zlei on Thu, Aug 7, 3:57 AM.
Tags
None
Referenced Files
F126698387: D51781.id159939.diff
Fri, Aug 22, 6:56 PM
Unknown Object (File)
Wed, Aug 20, 8:19 PM
Unknown Object (File)
Wed, Aug 20, 5:40 PM
Unknown Object (File)
Wed, Aug 20, 12:24 PM
Unknown Object (File)
Wed, Aug 20, 8:50 AM
Unknown Object (File)
Wed, Aug 20, 8:48 AM
Unknown Object (File)
Wed, Aug 20, 8:45 AM
Unknown Object (File)
Wed, Aug 20, 12:32 AM

Details

Reviewers
meta
Group Reviewers
network
manpages
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Thu, Aug 7, 3:57 AM

This is probably too late as the feature was introduced in 2005 [1]. Sigh...

[1] 73ff045c575b Add RFC 3378 EtherIP support ...

bridge.4 doesn't actually describe this beside a single example, but i'm not sure where the right place to do that would be. i've never liked that this feature depends on bridge, but since it does, bridge.4 is probably a better place.

share/man/man4/gif.4
31
60

i realise the rest of the manpage uses "IPv[46]", but it's much more standard to just say "IP" so we should prefer that in new text.

bcr added inline comments.
share/man/man4/gif.4
62

You need to make a line break after the sentence stop here.

In D51781#1182969, @ivy wrote:

bridge.4 doesn't actually describe this beside a single example, but i'm not sure where the right place to do that would be. i've never liked that this feature depends on bridge, but since it does, bridge.4 is probably a better place.

bridge.4 has an example for Ethernet over IPv4, but not Ethernet over IPv6,

The bridge can tunnel Ethernet across an IP internet using the EtherIP
protocol.  This can be combined with ipsec(4) to provide an encrypted
connection.  Create a gif(4) interface and set the local and remote IP
addresses for the tunnel, these are reversed on the remote bridge.

      ifconfig gif0 create
      ifconfig gif0 tunnel 1.2.3.4 5.6.7.8 up
      ifconfig bridge0 create
      ifconfig bridge0 addm fxp0 addm gif0 up

@meta mentioned,

and Ethernet over IPv6 was not working until 2021...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256820

That fix is for inbound processing of EtherIP packets. Well Ethernet over IPv6 was intended to work since the first introduction of the feature [1], although not documented. So I guess only little people knows that feature and stops experimenting Ethernet over IPv6 and until 2021 the bug was found.

interface can also tunnel Ethernet traffic over IPv[46]

I intended to mention the full feature. So probably bridge.4 also needs to be updated to reflect the reality.

[1] 73ff045c575b Add RFC 3378 EtherIP support.

mandoc syntax fixes.

  1. Aug -> August
  2. IPv[46] -> IPv4 or IPv6
  3. Added a line break
zlei marked 3 inline comments as done.Tue, Aug 12, 9:44 AM

Well, IP internet often refers to the whole IP network, and IPv4 and IPv6 are two version of IP protocol. So I think in bridge.4,

The bridge can tunnel Ethernet across an IP internet using the EtherIP protocol.

is clear.

Well, actually the bridge(4) does not tunnel, but the gif(4) do. Probably we should put the example of EtherIP and IPv[46] over IPv[46] setup into EXAMPLES section of gif(4).

Please add RFC 3378 to the reference section.

If I have to say, the example in the if_bridge(4) manual page should be in if_gif(4), but either is fine.

Added RFC 3378 to reference section.

I only have ports commit bit so I'm not sure I'm eligible to approve this but it LGTM now.

This revision is now accepted and ready to land.Wed, Aug 20, 8:54 AM

I only have ports commit bit so I'm not sure I'm eligible to approve this but it LGTM now.

I think that ( reviewing ) is OK even without src commit bit. The acceptance meant the reviewer's LGTM but not meant that the reviewer permit the author to commit.

@hrs Friendly ping. Does this look good to you ?