Details

sys/netinet/tcp_input.c
2624–2625	Can wrap these two lines into a single line now.
2698–2699	Can wrap these two lines into a single line now.
2736–2738	Looks like dead code to me, as here should be "th->th_ack == tp->snd_una".
2824	`* counter as per RFC 6675. The variable` <== one extra space I think a better read can be: `* t_dupacks as per RFC 6675. The variable`

Address comments from cc@ and add a condition as discussed with rscheff@.

tuexen marked 3 inline comments as done.Thu, Aug 7, 8:03 AM

tuexen marked an inline comment as done.

Thanks for the following improvements:

put the checks of "non-DUP-ACK" first
remove one tab indent
remove some dead code and the resume_partialack label
clear comments between line# [2597, 2633]
make sure advancing ACKs are counted as DUP-ACKs under the V_tcp_do_newsack toggle

Some minor clean-ups remain. I am good with this change.

sys/netinet/tcp_input.c
2815–2816	Do you mean this minor change for readability? KASSERT(SEQ_GT(th->th_ack, tp->snd_una), ("%s: SEQ_LEQ(th_ack, snd_una)", __func__));
2845–2846	Can remove this extra KASSERT() now, as we have removed the `resume_partialack` label.

This revision is now accepted and ready to land.Fri, Aug 8, 9:35 PM

Follow the last two suggestions from cc.

This revision now requires review to proceed.Wed, Aug 13, 6:33 PM

tuexen marked 2 inline comments as done.Wed, Aug 13, 6:33 PM

Use the condition of RFC 6675 only if V_tcp_do_newsack is true.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Aug 24, 11:30 PM

This revision was automatically updated to reflect the committed changes.

tcp: improve the condition for detecting duplicate ACKs
ClosedPublic
Actions