Differential D51739

libusb: implement libusb_wrap_sys_device
ClosedPublic
Actions

Authored by aokblast on Tue, Aug 5, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 24, 2:22 PM

	Unknown Object (File)
	Tue, Aug 19, 7:56 AM

	Unknown Object (File)
	Sun, Aug 17, 12:07 PM

	Unknown Object (File)
	Fri, Aug 15, 9:40 PM

	Unknown Object (File)
	Thu, Aug 14, 4:21 PM

	Unknown Object (File)
	Sun, Aug 10, 8:54 PM

	Unknown Object (File)
	Sun, Aug 10, 3:21 PM

	Unknown Object (File)
	Sun, Aug 10, 1:54 PM

View All 11 Files

Subscribers

Details

Reviewers

markj
lwhsu

Group Reviewers

Commits

rG872065688515: libusb: implement libusb_wrap_sys_device

Summary

The libusb_wrap_sys_device function can wrap an opened fd from the
system into a libusb handler. However, in FreeBSD's libusb implementation, a
USB device contains two fds: one for control transfers and another for
normal (bulk, interrupt, isochronous) transfers.

This design makes it impossible for FreeBSD to implement this function
without exposing a different structure in libusb.h to provide two fds.
Therefore, we return LIBUSB_ERROR_NOT_SUPPORTED to maintain API
compatibility.

Sponsored By: The FreeBSD Foundation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65973
Build 62856: arc lint + arc unit

Event Timeline

aokblast created this revision.Tue, Aug 5, 1:18 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Aug 5, 1:18 PM

aokblast requested review of this revision.Tue, Aug 5, 1:18 PM

Harbormaster completed remote builds in B65972: Diff 159765.Tue, Aug 5, 1:18 PM

aokblast added reviewers: markj, lwhsu.Tue, Aug 5, 1:21 PM

aokblast added a reviewer: manpages.

markj added inline comments.Tue, Aug 5, 1:24 PM

lib/libusb/libusb.3
215
lib/libusb/libusb10.c
1922	Extra newline.

Fixes

Harbormaster completed remote builds in B65973: Diff 159766.Tue, Aug 5, 1:32 PM

Approved

This revision is now accepted and ready to land.Tue, Aug 5, 1:36 PM

lwhsu accepted this revision.Wed, Aug 6, 4:36 AM

lwhsu added inline comments.

lib/libusb/libusb.3
213

Closed by commit rG872065688515: libusb: implement libusb_wrap_sys_device (authored by aokblast). · Explain WhyWed, Aug 6, 2:20 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG872065688515: libusb: implement libusb_wrap_sys_device.

Revision Contents
Changeset List

Path

Size

lib/

libusb/

1 line

8 lines

7 lines

Diff 159766

lib/libusb/libusb.h

Loading...

lib/libusb/libusb.3

Loading...

lib/libusb/libusb10.c

Loading...