Paths

Table of Contentst

Differential D51223

libusb: implement libusb_hotplug_get_user_data
ClosedPublic
Actions

Authored by aokblast on Jul 9 2025, 8:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 4, 8:52 PM

	Unknown Object (File)
	Mon, Aug 4, 2:25 AM

	Unknown Object (File)
	Mon, Aug 4, 12:50 AM

	Unknown Object (File)
	Mon, Jul 28, 11:49 AM

	Unknown Object (File)
	Mon, Jul 28, 9:30 AM

	Unknown Object (File)
	Mon, Jul 28, 8:31 AM

	Unknown Object (File)
	Mon, Jul 28, 8:01 AM

	Unknown Object (File)
	Mon, Jul 28, 6:00 AM

View All 11 Files

Subscribers

Details

Reviewers

bapt
kevans
markj
lwhsu

Group Reviewers

Commits

rG9ca855653f32: libusb: implement libusb_hotplug_get_user_data

Summary

libusb provides a function to get the callback userdata for a given
callback sincwe this structure is opaque to libusb user.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Jul 9 2025, 8:33 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptJul 9 2025, 8:33 AM

aokblast requested review of this revision.Jul 9 2025, 8:33 AM

Harbormaster completed remote builds in B65293: Diff 158209.Jul 9 2025, 8:33 AM

aokblast added reviewers: bapt, kevans, USB.Jul 9 2025, 8:38 AM

markj added a subscriber: markj.Fri, Jul 11, 1:39 PM

markj added inline comments.

lib/libusb/libusb.3
780
781
lib/libusb/libusb10_hotplug.c
429	Presumably you need to release the lock before returning? Or, just `break;` here, and `return (handle)` below. It is guaranteed that TAILQ_FOREACH will set the iterator variable to NULL after the loop reaches the end of the queue and terminates.

ziaee added inline comments.Fri, Jul 11, 2:54 PM

lib/libusb/libusb.3
780	`returns`?

markj added inline comments.Fri, Jul 11, 2:57 PM

lib/libusb/libusb.3
780	Yes, sorry.

hi! please address the concerns in the diff (including that lock handling, heh) and then i'll approve! thanks!

Minor updates

Harbormaster completed remote builds in B65450: Diff 158532.Tue, Jul 15, 7:41 AM

markj added inline comments.Tue, Jul 15, 1:38 PM

lib/libusb/libusb10_hotplug.c
433	Don't you want to return `handle` here?

Fix false return after drunk too much

Harbormaster completed remote builds in B65457: Diff 158547.Tue, Jul 15, 1:51 PM

Approved

This revision is now accepted and ready to land.Tue, Jul 15, 1:55 PM

lwhsu accepted this revision.Sun, Jul 20, 8:38 PM

lwhsu added a subscriber: lwhsu.

lwhsu added inline comments.

lib/libusb/libusb.h
597	don't forget to align the style with other functions.

Closed by commit rG9ca855653f32: libusb: implement libusb_hotplug_get_user_data (authored by aokblast). · Explain WhyMon, Jul 21, 6:17 AM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG9ca855653f32: libusb: implement libusb_hotplug_get_user_data.

Revision Contents
Changeset List

Path

Size

lib/

libusb/

2 lines

5 lines

libusb10_hotplug.c

18 lines

Diff 158850

lib/libusb/libusb.h

Loading...

lib/libusb/libusb.3

Loading...

lib/libusb/libusb10_hotplug.c

Loading...