Page MenuHomeFreeBSD

nvme_sim: Connect to events broadcast with nvmec_if
Needs ReviewPublic

Authored by imp on Thu, Jul 17, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 5, 3:54 PM
Unknown Object (File)
Tue, Jul 29, 2:27 AM
Unknown Object (File)
Mon, Jul 28, 7:08 PM
Unknown Object (File)
Mon, Jul 28, 5:40 PM
Unknown Object (File)
Mon, Jul 28, 3:10 PM
Unknown Object (File)
Sun, Jul 27, 2:57 PM
Unknown Object (File)
Sun, Jul 27, 12:36 PM
Unknown Object (File)
Fri, Jul 18, 12:50 AM
Subscribers

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65533
Build 62416: arc lint + arc unit

Event Timeline

sys/dev/nvme/nvme_sim.c
413

FWIW, in nvmf I just have a single namespace_changed callback. It parses the list of changed namespaces for the AEN and then calls nvmf_rescan_ns for each namespace. For the /dev/nvmeXnsY devices it does do some extra work to detect add vs remove vs change, but for the CAM SIM, it just always calls nvmf_sim_rescan_ns that just triggers an xpt_rescan for the namespace.

sys/dev/nvme/nvme_sim.c
413

Yea. 'new' is called at startup, while my delta is called for the AER change event. I don't have a rm event yet.

I'm happy to tweak things, especially if an xpt_rescan does the right thing.

413

Also, that's how it is with these changes, but not set in stone if we can make things simpler.