Paths

Table of Contentst

Differential D51221

libusb: implement libusb_free_pollfds
ClosedPublic
Actions

Authored by aokblast on Jul 9 2025, 7:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 26, 6:24 PM

	Unknown Object (File)
	Thu, Oct 23, 5:08 AM

	Unknown Object (File)
	Wed, Oct 22, 11:44 PM

	Unknown Object (File)
	Sun, Oct 12, 7:02 AM

	Unknown Object (File)
	Fri, Oct 10, 9:53 PM

	Unknown Object (File)
	Fri, Oct 10, 9:53 PM

	Unknown Object (File)
	Fri, Oct 10, 4:02 PM

	Unknown Object (File)
	Fri, Oct 10, 4:02 PM

View All 30 Files

Subscribers

schweikh_schweikhardt.net

Details

Reviewers

bapt
kevans
adrian
markj
lwhsu

Group Reviewers

Commits

rG1c675fb36545: libusb: implement libusb_free_pollfds

Summary

The libusb has a API that free the storage for pollfds whatever the
content is. There is no check on if the fd inside is closed.

Sponsored by: FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65448
Build 62331: arc lint + arc unit

Event Timeline

aokblast created this revision.Jul 9 2025, 7:40 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptJul 9 2025, 7:40 AM

aokblast requested review of this revision.Jul 9 2025, 7:40 AM

Harbormaster completed remote builds in B65291: Diff 158207.Jul 9 2025, 7:40 AM

aokblast added reviewers: bapt, kevans, USB.Jul 9 2025, 7:41 AM

Looks ok to me with the man page nits fixed.

lib/libusb/libusb.3
768
769
lib/libusb/libusb10_io.c
847	It's weird that this is `const`, but I see it is the same upstream as well.
850	free(NULL) is ok too, you don't really need this check, but it's fine either way.

In the function prototypes the asterisks for pointers should all be consistent without a space next to the identifier. All "* ctx" should be "*ctx".
There is no need to cast the argument of free(), since it takes a ptr-to-void and they are assignment compatible to any pointer.

adrian accepted this revision.Jul 11 2025, 4:41 PM

This revision is now accepted and ready to land.Jul 11 2025, 4:41 PM

In D51221#1170384, @schweikh_schweikhardt.net wrote:

In the function prototypes the asterisks for pointers should all be consistent without a space next to the identifier. All "* ctx" should be "*ctx".

There is no need to cast the argument of free(), since it takes a ptr-to-void and they are assignment compatible to any pointer.

Hello schweikh, thanks for your review!

The asterisks is not from me but the previous work. I am thinking about submit a patch about doing clang-format on libusb.h. However, it is unrelated to this patch.

lib/libusb/libusb10_io.c
847	Yes, I would like to follow the upstream interface to prevent the compile warning or error (if werror-all enable).

Minor fixes

This revision now requires review to proceed.Jul 15 2025, 7:23 AM

Harbormaster completed remote builds in B65448: Diff 158530.Jul 15 2025, 7:23 AM

Approved, with the one style nit fixed.

lib/libusb/libusb.h
582	Please keep the indentation consistent, it looks like there should be a tab after `void` here.

This revision is now accepted and ready to land.Jul 15 2025, 1:36 PM

lwhsu accepted this revision.Jul 20 2025, 8:35 PM

Closed by commit rG1c675fb36545: libusb: implement libusb_free_pollfds (authored by aokblast). · Explain WhyJul 21 2025, 6:17 AM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG1c675fb36545: libusb: implement libusb_free_pollfds.

Revision Contents
Changeset List

Path

Size

lib/

libusb/

3 lines

6 lines

9 lines

Diff 158530

lib/libusb/libusb.h

Loading...

lib/libusb/libusb.3

Loading...

lib/libusb/libusb10_io.c

Loading...