libusb provides a function to get the callback userdata for a given
callback sincwe this structure is opaque to libusb user.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 65293 Build 62176: arc lint + arc unit
Event Timeline
| lib/libusb/libusb.3 | ||
|---|---|---|
| 767 | ||
| 768 | ||
| lib/libusb/libusb10_hotplug.c | ||
| 429 | Presumably you need to release the lock before returning? Or, just break; here, and return (handle) below. It is guaranteed that TAILQ_FOREACH will set the iterator variable to NULL after the loop reaches the end of the queue and terminates. | |
| lib/libusb/libusb.3 | ||
|---|---|---|
| 767 | returns? | |
| lib/libusb/libusb.3 | ||
|---|---|---|
| 767 | Yes, sorry. | |
Comment Actions
hi! please address the concerns in the diff (including that lock handling, heh) and then i'll approve! thanks!
| lib/libusb/libusb10_hotplug.c | ||
|---|---|---|
| 433 | Don't you want to return handle here? | |
| lib/libusb/libusb.h | ||
|---|---|---|
| 601 | don't forget to align the style with other functions. | |