uexterr_gettext: add tests
ClosedPublic
Actions

Authored by asomers on Jul 6 2025, 8:16 PM.

Details

Reviewers

arrowd
kib

Commits

rG874385b03f8d: uexterr_gettext: add tests

Summary

Add tests for the new extended errno feature, using a custom kernel
module to report errors to userland.

Sponsored by: ConnectWise
MFC after: 2 weeks

Abandon the custom kernel module. Rely on existing syscalls instead.

move the test into the kern directory

Now that the custom kld is gone, it doesn't need its own directory.

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65241
Build 62124: arc lint + arc unit

asomers requested review of this revision.Jul 6 2025, 8:16 PM

kib accepted this revision.Jul 6 2025, 9:06 PM

kib added inline comments.

sys/kern/sys_generic.c
2316	Add FALLTHROUGH annotation?
tests/sys/kern/exterr_test.c
53	I never intended for the returned strings to be part of the ABI.

This revision is now accepted and ready to land.Jul 6 2025, 9:06 PM

tests/sys/kern/exterr_test.c
53	Yeah, I didn't want to assume that the strings would never change. That's why I created a custom kernel module, at first. Would you like some other assertion instead of this?

tests/sys/kern/exterr_test.c
53	Might be a simple approach is to add a comment that the string in the test might need to be updated if kernel changed, and this is not a functional failure then.