Page MenuHomeFreeBSD
Differential D51001

lualoader: Add distinct brand for installer
ClosedPublic
Actions

Authored by jrm on Jun 24 2025, 4:08 AM.
Tags
None
Referenced Files
F132483633: D51001.id157524.diff
Fri, Oct 17, 7:32 AM
Unknown Object (File)
Thu, Oct 16, 4:01 PM
Unknown Object (File)
Thu, Oct 9, 9:17 PM
Unknown Object (File)
Fri, Oct 3, 10:00 AM
Unknown Object (File)
Thu, Oct 2, 4:31 AM
Unknown Object (File)
Mon, Sep 29, 10:07 PM
Unknown Object (File)
Mon, Sep 29, 10:06 PM
Unknown Object (File)
Mon, Sep 29, 10:06 PM
View All 40 Files
Subscribers
dab
jrtc27

Details

Reviewers
kevans
imp
emaste
manu
Commits
rGac7a19d41ee5: lualoader: Add distinct brand for installer
Summary

Make it obvious to users that the system is booting into the installer.

Event: Kitchener-Waterloo Hackathon 202506
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65038
Build 61921: arc lint + arc unit

Event Timeline

jrm created this revision.Jun 24 2025, 4:08 AM
Herald added a reviewer: manu. · View Herald TranscriptJun 24 2025, 4:08 AM
Herald added subscribers: jrtc27, dab. · View Herald Transcript
jrm requested review of this revision.Jun 24 2025, 4:08 AM
Harbormaster completed remote builds in B65038: Diff 157497.Jun 24 2025, 4:08 AM
jrm added a comment.Jun 24 2025, 4:11 AM

Screenshot:

image.png (1×1 px, 2 MB)

manu accepted this revision.Jun 24 2025, 6:18 AM

Nice !

This revision is now accepted and ready to land.Jun 24 2025, 6:18 AM
kevans accepted this revision.Jun 24 2025, 12:12 PM
kevans added inline comments.
stand/lua/gfx-install.lua
23

You should be able to omit the unnecessary shift, as long as one isn't specified in the brand table directly we shouldn't try to apply anything beyond the global shift iirc.

Closed by commit rGac7a19d41ee5: lualoader: Add distinct brand for installer (authored by jrm). · Explain WhyJun 24 2025, 3:13 PM
This revision was automatically updated to reflect the committed changes.
jrm added a commit: rGac7a19d41ee5: lualoader: Add distinct brand for installer.

Revision Contents
Changeset List

PathSize
release/
3 lines
stand/
images/
3 lines
lua/
1 line
26 lines

Diff 157497

View Options

release/Makefile

Loading...
View Options

stand/images/Makefile

Loading...
View Options

stand/images/freebsd-install-brand-rev.png

Loading...
View Options

stand/lua/Makefile

Loading...
View Options

stand/lua/gfx-install.lua

Loading...