Differential D50588

style: Use static consistently
ClosedPublic
Actions

Authored by imp on May 28 2025, 9:49 PM.

Tags

None

Referenced Files

	F153144884: D50588.id.diff
	Sun, Apr 19, 11:20 AM

	F153125882: D50588.id156266.diff
	Sun, Apr 19, 8:26 AM

	F153120606: D50588.id156308.diff
	Sun, Apr 19, 7:32 AM

	F153108268: D50588.id156235.diff
	Sun, Apr 19, 5:24 AM

	Unknown Object (File)
	Fri, Apr 17, 9:59 AM

	Unknown Object (File)
	Thu, Apr 16, 9:24 PM

	Unknown Object (File)
	Sat, Apr 11, 8:47 PM

	Unknown Object (File)
	Thu, Apr 9, 12:08 PM

View All 88 Files

Subscribers

Details

Reviewers

chs
kevans
jhibbits
tsoome
manu

Commits

rGaeb446be4ea2: style: Use static consistently

Summary

C doesn't require that we have static on both the declaration and
definition of a function. But stylistically, FreeBSD does. Make that
so. Also make a function static that wasn't because, it seems, that
static and struct look a lot alike in a column of text.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64519
Build 61403: arc lint + arc unit

Event Timeline

imp created this revision.May 28 2025, 9:49 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 28 2025, 9:49 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.May 28 2025, 9:49 PM

Harbormaster completed remote builds in B64519: Diff 156235.May 28 2025, 9:49 PM

imp added a parent revision: D50587: stand: Retire arch_loadaddr, pending its replacement.May 28 2025, 9:49 PM

imp added a child revision: D50589: kboot: Create quit command.

jhibbits accepted this revision.May 29 2025, 12:57 PM

This revision is now accepted and ready to land.May 29 2025, 12:57 PM

Update per review

This revision now requires review to proceed.May 29 2025, 6:18 PM

Harbormaster completed remote builds in B64537: Diff 156266.May 29 2025, 6:18 PM

tsoome accepted this revision.May 30 2025, 6:49 AM

This revision is now accepted and ready to land.May 30 2025, 6:49 AM

Closed by commit rGaeb446be4ea2: style: Use static consistently (authored by imp). · Explain WhyMay 30 2025, 3:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaeb446be4ea2: style: Use static consistently.

Revision Contents
Changeset List

Path

Size

stand/

common/

8 lines

Diff 156235

stand/common/module.c

Loading...