Page MenuHomeFreeBSD
Differential D50383

release/Makefile: Refactor dist set logic
ClosedPublic
Actions

Authored by emaste on May 16 2025, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 29, 11:21 PM
Unknown Object (File)
Sun, Mar 29, 3:11 AM
Unknown Object (File)
Sun, Mar 29, 12:50 AM
Unknown Object (File)
Wed, Mar 25, 2:31 AM
Unknown Object (File)
Mon, Mar 23, 7:19 PM
Unknown Object (File)
Thu, Mar 19, 9:23 AM
Unknown Object (File)
Mon, Mar 9, 9:39 PM
Unknown Object (File)
Sat, Mar 7, 7:06 PM
View All Files
Subscribers
imp
jrtc27

Details

Reviewers
ifreund_freebsdfoundation.org
bz
jrm
Group Reviewers
releng
pkgbase
Commits
rGb8ae4def0fc0: release: Refactor dist set logic
Summary

Add to the METALOG immediately following the operation itself to make
the logic easier to follow. Fuse adjacent identical loops. Both of
these are possible as we no longer have a separate path for NO_ROOT
builds.

Move MANIFEST out of the loops for disc1 and dvd1 and copy it
explicitly, so that all three MANIFEST operations are identical, and
shared by pkgbase and legacy code paths for disc1 and dvd1.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.May 16 2025, 7:11 PM
Herald added a subscriber: jrtc27. · View Herald TranscriptMay 16 2025, 7:11 PM
emaste requested review of this revision.May 16 2025, 7:11 PM
emaste updated this revision to Diff 155579.May 16 2025, 7:27 PM
emaste edited the summary of this revision. (Show Details)

Move MANIFEST out of the loops for disc1 and dvd1 and copy it explicitly, so that all three MANIFEST operations are identical (for upcoming pkgbase work).

emaste added a comment.May 16 2025, 7:53 PM

Note that this conflicts with D50346. Ideally I'd land this first, but Isaac is AFK for a bit and I'm inclined to land D50346 and iterate in tree.

emaste updated this revision to Diff 155773.May 20 2025, 8:53 PM
emaste edited the summary of this revision. (Show Details)

Rebase after D50346

emaste mentioned this in D50346: release: add -DPKGBASE option.May 20 2025, 9:41 PM
emaste added reviewers: ifreund_freebsdfoundation.org, pkgbase.May 21 2025, 12:47 PM
emaste added a reviewer: bz.May 26 2025, 7:47 PM
emaste updated this revision to Diff 156256.May 29 2025, 4:07 PM

Slight clarification on comment -- MANIFEST provides checksums for the legacy dist sets

jrm added a reviewer: jrm.Jun 16 2025, 11:00 PM
jrm accepted this revision.Jun 17 2025, 3:52 PM
This revision is now accepted and ready to land.Jun 17 2025, 3:52 PM
Closed by commit rGb8ae4def0fc0: release: Refactor dist set logic (authored by emaste). · Explain WhyJun 17 2025, 5:23 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGb8ae4def0fc0: release: Refactor dist set logic.
Herald added a subscriber: imp. · View Herald TranscriptJun 17 2025, 5:23 PM

Revision Contents
Changeset List

PathSize
release/
22 lines

Diff 155579

View Options

release/Makefile

Loading...