Differential D50084

strings: Unconditionally install ELF Tool Chain's strings
ClosedPublic
Actions

Authored by emaste on Apr 30 2025, 2:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 19, 5:07 AM

	Unknown Object (File)
	Sat, Jul 26, 9:17 AM

	Unknown Object (File)
	Sat, Jul 26, 12:25 AM

	Unknown Object (File)
	Fri, Jul 25, 12:03 PM

	Unknown Object (File)
	Jul 13 2025, 3:01 AM

	Unknown Object (File)
	Jul 11 2025, 9:31 AM

	Unknown Object (File)
	Jul 8 2025, 7:32 PM

	Unknown Object (File)
	Jul 8 2025, 3:55 PM

View All 34 Files

Subscribers

Details

Reviewers

olivier
me_cameronkatri.com
arichardson
dim
brooks

Commits

rGfbd7087b0be2: strings: Unconditionally install ELF Tool Chain's strings

Summary

Reported by olivier - `cat coredump | strings` resulted in reading 1G into memory before producing any output. We always install strings (regardless of WITH_/WITHOUT_TOOLCHAIN) and ELF Tool Chain's version is small and lightweight. Go back to always installing ELF Tool Chain's version.

This reverts commit 81fa5c4a828bec9f1ead280c59c31bd423e6eeea.
This reverts commit 7ca3db1999cd967f9d6d7b259aa7af54aae14a5f.

PR: 286605

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Apr 30 2025, 2:01 PM

Herald added a subscriber: ziaee. · View Herald TranscriptApr 30 2025, 2:01 PM

emaste requested review of this revision.Apr 30 2025, 2:01 PM

emaste edited the summary of this revision. (Show Details)May 5 2025, 3:30 PM

emaste added a reviewer: dim.May 5 2025, 3:56 PM

emaste added a reviewer: brooks.

olivier accepted this revision.May 5 2025, 4:46 PM

This revision is now accepted and ready to land.May 5 2025, 4:46 PM

brooks accepted this revision.May 5 2025, 6:42 PM

dim accepted this revision.May 5 2025, 7:36 PM

@dim sorry I pushed just before your acceptance

Closed by commit rGfbd7087b0be2: strings: Unconditionally install ELF Tool Chain's strings (authored by emaste). · Explain WhyMay 5 2025, 7:39 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGfbd7087b0be2: strings: Unconditionally install ELF Tool Chain's strings.

Herald added a subscriber: imp. · View Herald TranscriptMay 5 2025, 7:39 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man5/

tools/

build/

options/

WITHOUT_LLVM_BINUTILS

2 lines

WITH_LLVM_BINUTILS

2 lines

usr.bin/

8 lines

clang/

llvm-strings/

7 lines

Diff 154897

share/man/man5/src.conf.5

Loading...

tools/build/options/WITHOUT_LLVM_BINUTILS

Loading...

tools/build/options/WITH_LLVM_BINUTILS

Loading...

usr.bin/Makefile

Loading...

usr.bin/clang/llvm-strings/Makefile

Loading...