stand: Enable Spleen 32x64 font in the bootloader
ClosedPublic
Actions

Authored by ziaee on Apr 10 2025, 10:24 PM.

Details

Reviewers

carlavilla
emaste
mhorne
• rea
manu
adrian
imp
tsoome

Group Reviewers

Loader

Commits

rG1ec2c8b2f364: stand: Enable Spleen 32x64 font in the bootloader

Summary

Spleen 32x64 provides my 14" 2560x1600 display with the ancestral 80x25,
BSD standard console. We already include it in contrib, and it is built
for the runtime vt(4) font directory, but was previously unavailable to
the bootloader. Enable it in the build.

Bugs: This is only necessary if using a high DPI display, and in that
case the font isn't really 64pt.

MFC after: 3 days

Test Plan

<as root>
cd /usr/src && tools/tools/git/git-arc.sh patch -c D49768 && echo 'screen.font="32x64"' >> /boot/loader.conf && reboot

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63438
Build 60322: arc lint + arc unit

Event Timeline

ziaee created this revision.Apr 10 2025, 10:24 PM

Herald added a reviewer: manu. · View Herald TranscriptApr 10 2025, 10:24 PM

Herald added subscribers: dab, imp. · View Herald Transcript

ziaee requested review of this revision.Apr 10 2025, 10:24 PM

Harbormaster completed remote builds in B63438: Diff 153480.Apr 10 2025, 10:24 PM

ziaee added a comment.Apr 10 2025, 11:18 PM

This comment was removed by ziaee.

ziaee added a comment.Apr 12 2025, 11:30 PM

This comment was removed by ziaee.

ziaee edited the summary of this revision. (Show Details)Apr 13 2025, 1:58 AM

ziaee retitled this revision from stand: Enable Spleen 64 to stand: Enable Spleen 32x64 font in the bootloader.

ziaee added a reviewer: Loader.Apr 14 2025, 2:12 PM

adrian accepted this revision.Apr 17 2025, 6:05 PM

This revision is now accepted and ready to land.Apr 17 2025, 6:05 PM

@ziaee I cannot approve this change since I don't have enough knowledge to know if the change is ok.

@emaste can we go ahead with this change?

ziaee edited the test plan for this revision. (Show Details)May 5 2025, 11:58 PM

imp accepted this revision.May 6 2025, 12:22 AM

tsoome accepted this revision.May 6 2025, 6:09 AM

Approved; with @imp and @tsoome's review I think you can proceed.

Closed by commit rG1ec2c8b2f364: stand: Enable Spleen 32x64 font in the bootloader (authored by ziaee). · Explain WhyMay 6 2025, 3:52 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG1ec2c8b2f364: stand: Enable Spleen 32x64 font in the bootloader.

I disgraced the commit log here. @emaste did not review this. I was thinking of him teaching me about Makefile but that was a completely different review.

jrm added a reverting change: D52402: stand: Remove Spleen 32x64 fonts from INDEX.Fri, Sep 5, 7:40 PM