socket: Check for a NULL ctloutput handler in the SO_SETFIB handler
ClosedPublic
Actions

Authored by markj on Mar 21 2025, 2:08 PM.

Details

Reviewers

Commits

rG52465324497a: socket: Handle the possibility of a protocol with no ctloutput
rG590b45036ee1: socket: Handle the possibility of a protocol with no ctloutput

Summary

Some protocols, e.g., ng_btsocket_l2cap_raw_protosw, do not have one.

Reported by: syzkaller
Fixes: caccbaef8e26 ("socket: Move SO_SETFIB handling to protocol layers")
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63062
Build 59946: arc lint + arc unit

Event Timeline

markj created this revision.Mar 21 2025, 2:08 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 21 2025, 2:08 PM

markj requested review of this revision.Mar 21 2025, 2:08 PM

Harbormaster completed remote builds in B63022: Diff 152494.Mar 21 2025, 2:08 PM

I would do it differently. In uipc_domain.c add pr_ctloutput_notsupp() and add it with NOTSUPP() macro to pr_init() in the same file.

Apply Gleb's suggestion.

Harbormaster completed remote builds in B63062: Diff 152549.Mar 23 2025, 9:34 AM

Thanks!

This revision is now accepted and ready to land.Mar 24 2025, 6:34 AM

Closed by commit rG590b45036ee1: socket: Handle the possibility of a protocol with no ctloutput (authored by markj). · Explain WhyMar 31 2025, 9:06 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG590b45036ee1: socket: Handle the possibility of a protocol with no ctloutput.

markj added a commit: rG52465324497a: socket: Handle the possibility of a protocol with no ctloutput.Apr 15 2025, 2:25 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_domain.c

7 lines

uipc_socket.c

12 lines

Diff 152549

View Options

sys/kern/uipc_domain.c