Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGe4458d4d71c4: sound: Make CHN_REMOVE_SAFE() the default
rGffcefe5310e0: sound: Make CHN_REMOVE_SAFE() the default

Summary

FILLME optimized CHN_REMOVE_SAFE() to perform almost equally to
CHN_REMOVE(), so we can turn CHN_REMOVE_SAFE() into CHN_REMOVE() without
fears of performance regressions, while also being more robust.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Dec 29 2024, 8:51 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2024, 8:51 PM

christos requested review of this revision.Dec 29 2024, 8:51 PM

Harbormaster completed remote builds in B61399: Diff 148539.Dec 29 2024, 8:51 PM

christos added a parent revision: D48207: sound: Safely remove channel from list in one pass.Dec 29 2024, 8:54 PM

christos mentioned this in D48185: sound: Do not fail from vchan_destroy() if children list is empty.Dec 29 2024, 8:55 PM

christos added a child revision: D48185: sound: Do not fail from vchan_destroy() if children list is empty.Dec 29 2024, 8:59 PM

dev_submerge.ch accepted this revision.Dec 29 2024, 10:23 PM

This revision is now accepted and ready to land.Dec 29 2024, 10:23 PM

Closed by commit rGffcefe5310e0: sound: Make CHN_REMOVE_SAFE() the default (authored by christos). · Explain WhyJan 21 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGffcefe5310e0: sound: Make CHN_REMOVE_SAFE() the default.

christos added a commit: rGe4458d4d71c4: sound: Make CHN_REMOVE_SAFE() the default.Jan 28 2025, 2:05 PM

sound: Make CHN_REMOVE_SAFE() the default
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 149660

sys/dev/sound/pcm/channel.h

sys/dev/sound/pcm/channel.c

sound: Make CHN_REMOVE_SAFE() the defaultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 149660

sys/dev/sound/pcm/channel.h

sys/dev/sound/pcm/channel.c

sound: Make CHN_REMOVE_SAFE() the default
ClosedPublic
Actions

Revision Contents
Changeset List