Page MenuHomeFreeBSD
Differential D48341

TCP BBR: remove dead code
ClosedPublic
Actions

Authored by tuexen on Jan 6 2025, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 26, 10:43 AM
Unknown Object (File)
Sat, Aug 16, 4:39 AM
Unknown Object (File)
Wed, Aug 13, 11:13 PM
Unknown Object (File)
Tue, Aug 12, 10:39 PM
Unknown Object (File)
Sun, Aug 10, 8:07 AM
Unknown Object (File)
Sun, Aug 10, 6:23 AM
Unknown Object (File)
Sun, Aug 10, 5:25 AM
Unknown Object (File)
Fri, Aug 8, 11:56 AM
View All 52 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rrs
rscheff
cc
peter.lei_ieee.org
lstewart
Group Reviewers
transport
Commits
rGdc66be9b6258: TCP BBR: remove dead code
rGf28415489639: TCP BBR: remove dead code
rGe7fbf52a3e38: TCP BBR: remove dead code
Summary

No functional change intended.
CID: 1523802

This is a last fix for BBR in this series.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Jan 6 2025, 8:37 PM
Herald added a reviewer: transport. · View Herald TranscriptJan 6 2025, 8:37 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Jan 6 2025, 8:37 PM
peter.lei_ieee.org added inline comments.Jan 8 2025, 4:06 PM
sys/netinet/tcp_stacks/bbr.c
6827

I think this if ((int) t <= 0) condition could also be removed for similar reasons?

rrs accepted this revision.Jan 8 2025, 6:09 PM

I agree with Peter :)

This revision is now accepted and ready to land.Jan 8 2025, 6:09 PM
cc accepted this revision.Jan 8 2025, 8:16 PM
tuexen updated this revision to Diff 148944.Jan 8 2025, 9:41 PM

Address comment raised by Peter. Coverity also reported it, which I overlooked.

This revision now requires review to proceed.Jan 8 2025, 9:41 PM
peter.lei_ieee.org accepted this revision.Jan 9 2025, 12:01 AM
This revision is now accepted and ready to land.Jan 9 2025, 12:01 AM
Closed by commit rGe7fbf52a3e38: TCP BBR: remove dead code (authored by tuexen). · Explain WhyJan 9 2025, 5:29 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGe7fbf52a3e38: TCP BBR: remove dead code.
tuexen added a commit: rGf28415489639: TCP BBR: remove dead code.Feb 5 2025, 9:03 PM
tuexen added a commit: rGdc66be9b6258: TCP BBR: remove dead code.

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
4 lines

Diff 148944

View Options

sys/netinet/tcp_stacks/bbr.c

Loading...