TCP RACK: remove variable with is only initialized and not changed
ClosedPublic
Actions

Authored by tuexen on Jan 4 2025, 3:00 PM.

Details

Reviewers

rrs
rscheff
cc
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rG1d8bbe5ba370: TCP RACK: remove variable with is only initialized and not changed
rG84e894ce1309: TCP RACK: remove variable with is only initialized and not changed

Summary

minslot is initialized to 0 and never changed. It is not clear to me under which condition minslot should be set to which value.
Therefore, remove it and the code checking that it is not zero.
No functional change intended.
CID: 1523812

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jan 4 2025, 3:00 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 4 2025, 3:00 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jan 4 2025, 3:00 PM

tuexen edited the summary of this revision. (Show Details)Jan 4 2025, 4:44 PM

old code :)

This revision is now accepted and ready to land.Jan 4 2025, 6:32 PM

Closed by commit rG84e894ce1309: TCP RACK: remove variable with is only initialized and not changed (authored by tuexen). · Explain WhyJan 4 2025, 8:15 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG84e894ce1309: TCP RACK: remove variable with is only initialized and not changed.

tuexen added a commit: rG1d8bbe5ba370: TCP RACK: remove variable with is only initialized and not changed.Feb 5 2025, 8:53 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

6 lines

Diff 148780

View Options

sys/netinet/tcp_stacks/rack.c

TCP RACK: remove variable with is only initialized and not changedClosedPublicActions