Use bus_generic_detach to detach and delete child devices during detach
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:31 PM.

Details

Reviewers

imp
andrew

Commits

rG11a9117871e6: Use bus_generic_detach to detach and delete child devices during detach

Summary

This is simpler and more robust than individual calls to
device_delete_child.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61013
Build 57897: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 6 2024, 10:31 PM

Herald added a reviewer: andrew. · View Herald TranscriptDec 6 2024, 10:31 PM

jhb requested review of this revision.Dec 6 2024, 10:31 PM

jhb added a parent revision: D47971: spibus: Use bus_generic_* directly instead of wrappers.

jhb added a child revision: D47973: mfi: Use bus_generic_detach to simplify deleting children during detach.

Harbormaster completed remote builds in B61013: Diff 147650.Dec 6 2024, 10:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2025, 6:29 PM

Closed by commit rG11a9117871e6: Use bus_generic_detach to detach and delete child devices during detach (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG11a9117871e6: Use bus_generic_detach to detach and delete child devices during detach.

Revision Contents
Changeset List

Path

Size

sys/

arm/

ti/

twl/

twl.c

8 lines

dev/

aac/

aac.c

10 lines

aacraid/

aacraid.c

7 lines

alpm/

alpm.c

9 lines

altera/

atse/

if_atse.c

4 lines

amdpm/

amdpm.c

8 lines

amdsmb/

amdsmb.c

8 lines

cas/

if_cas.c

2 lines

enetc/

if_enetc.c

3 lines

gem/

if_gem.c

2 lines

mgb/

if_mgb.c

3 lines

mlx/

mlx.c

14 lines

nfsmb/

nfsmb.c

21 lines

puc/

puc.c

18 lines

sound/

pci/

hda/

hdac.c

15 lines

usb/

net/

usb_ethernet.c

8 lines

virtio/

mmio/

virtio_mmio.c

10 lines

pci/

virtio_pci.c

12 lines

xilinx/

if_xae.c

3 lines

Diff 147650

View Options

sys/arm/ti/twl/twl.c

View Options

sys/dev/aac/aac.c

View Options

sys/dev/aacraid/aacraid.c

View Options

sys/dev/alpm/alpm.c

View Options

sys/dev/altera/atse/if_atse.c

View Options

sys/dev/amdpm/amdpm.c

View Options

sys/dev/amdsmb/amdsmb.c

View Options

sys/dev/cas/if_cas.c

View Options

sys/dev/enetc/if_enetc.c

View Options

sys/dev/gem/if_gem.c

View Options

sys/dev/mgb/if_mgb.c

View Options

sys/dev/mlx/mlx.c

View Options

sys/dev/nfsmb/nfsmb.c

View Options

sys/dev/puc/puc.c

View Options

sys/dev/sound/pci/hda/hdac.c

View Options

sys/dev/usb/net/usb_ethernet.c

View Options

sys/dev/virtio/mmio/virtio_mmio.c

View Options

sys/dev/virtio/pci/virtio_pci.c

View Options

Use bus_generic_detach to detach and delete child devices during detachClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147650

sys/arm/ti/twl/twl.c

sys/dev/aac/aac.c

sys/dev/aacraid/aacraid.c

sys/dev/alpm/alpm.c

sys/dev/altera/atse/if_atse.c

sys/dev/amdpm/amdpm.c

sys/dev/amdsmb/amdsmb.c

sys/dev/cas/if_cas.c

sys/dev/enetc/if_enetc.c

sys/dev/gem/if_gem.c

sys/dev/mgb/if_mgb.c

sys/dev/mlx/mlx.c

sys/dev/nfsmb/nfsmb.c

sys/dev/puc/puc.c

sys/dev/sound/pci/hda/hdac.c

sys/dev/usb/net/usb_ethernet.c

sys/dev/virtio/mmio/virtio_mmio.c

sys/dev/virtio/pci/virtio_pci.c

sys/dev/xilinx/if_xae.c

Use bus_generic_detach to detach and delete child devices during detach
ClosedPublic
Actions

Revision Contents
Changeset List