bhnd bcma/siba: Remove duplicate call to device_delete_children
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:31 PM.

Tags

None

Referenced Files

	F159163531: D47968.id148692.diff
	Wed, Jun 10, 7:52 PM

	F159142812: D47968.id.diff
	Wed, Jun 10, 2:14 PM

	F159085926: D47968.id147646.diff
	Tue, Jun 9, 11:03 PM

	Unknown Object (File)
	Mon, Jun 8, 10:59 AM

	Unknown Object (File)
	Wed, Jun 3, 12:15 AM

	Unknown Object (File)
	Mon, May 11, 11:07 PM

	Unknown Object (File)
	Mon, May 11, 10:53 PM

	Unknown Object (File)
	Mon, May 11, 10:48 PM

View All 72 Files

Subscribers

None

Details

Reviewers

imp

Commits

rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children

Summary

bcma/siba_add_children already call device_delete_children if an error
occurs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 6 2024, 10:31 PM

jhb created this revision.

jhb added a parent revision: D47967: siba: Use device_delete_children in siba_add_children.

Harbormaster completed remote builds in B61009: Diff 147646.Dec 6 2024, 10:31 PM

jhb added a child revision: D47969: Use bus_generic_detach instead of device_delete_children in detach.Dec 6 2024, 10:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2025, 6:29 PM

Closed by commit rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG20f932af2973: bhnd bcma/siba: Remove duplicate call to device_delete_children.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bcma/

bcma.c

1 line

siba/

siba.c

1 line

Diff 148692

View Options

sys/dev/bhnd/bcma/bcma.c