Page MenuHomeFreeBSD
Differential D47970

etherswitch: Cleanup detach and delete of child devices during detach
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:31 PM.
Tags
None
Referenced Files
F136816900: D47970.id148694.diff
Wed, Nov 19, 7:29 PM
Unknown Object (File)
Sat, Nov 8, 3:45 AM
Unknown Object (File)
Tue, Nov 4, 1:10 AM
Unknown Object (File)
Wed, Oct 29, 9:39 AM
Unknown Object (File)
Wed, Oct 29, 9:24 AM
Unknown Object (File)
Tue, Oct 28, 11:32 AM
Unknown Object (File)
Mon, Oct 27, 2:01 PM
Unknown Object (File)
Oct 14 2025, 5:43 AM
View All 37 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGaa48c1ae0831: etherswitch: Cleanup detach and delete of child devices during detach
Summary

Call bus_generic_detach first and return any error. Remove no longer
needed individual device_delete_child calls.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 6 2024, 10:31 PM
jhb created this revision.
jhb added a parent revision: D47969: Use bus_generic_detach instead of device_delete_children in detach.
jhb added a child revision: D47971: spibus: Use bus_generic_* directly instead of wrappers.
Harbormaster completed remote builds in B61011: Diff 147648.Dec 6 2024, 10:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 2 2025, 6:29 PM
Closed by commit rGaa48c1ae0831: etherswitch: Cleanup detach and delete of child devices during detach (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGaa48c1ae0831: etherswitch: Cleanup detach and delete of child devices during detach.

Revision Contents
Changeset List

PathSize
sys/
dev/
etherswitch/
ar40xx/
9 lines
arswitch/
9 lines
e6000sw/
9 lines
infineon/
9 lines
ip17x/
9 lines
micrel/
9 lines
mtkswitch/
9 lines
rtl8366/
9 lines
ukswitch/
9 lines

Diff 148694

View Options

sys/dev/etherswitch/ar40xx/ar40xx_main.c

Loading...
View Options

sys/dev/etherswitch/arswitch/arswitch.c

Loading...
View Options

sys/dev/etherswitch/e6000sw/e6060sw.c

Loading...
View Options

sys/dev/etherswitch/infineon/adm6996fc.c

Loading...
View Options

sys/dev/etherswitch/ip17x/ip17x.c

Loading...
View Options

sys/dev/etherswitch/micrel/ksz8995ma.c

Loading...
View Options

sys/dev/etherswitch/mtkswitch/mtkswitch.c

Loading...
View Options

sys/dev/etherswitch/rtl8366/rtl8366rb.c

Loading...
View Options

sys/dev/etherswitch/ukswitch/ukswitch.c

Loading...