Remove now-redundant calls to device_delete_child
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:31 PM.

Details

Reviewers

imp
andrew
manu
jhb

Commits

rG4e62c3cafa4c: Remove now-redundant calls to device_delete_child

Summary

Deleting a child explicitly before calling bus_generic_detach is now
redundant, so remove those calls and rely on bus_generic_detach to
delete children instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61002
Build 57886: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 6 2024, 10:31 PM

Herald added a reviewer: andrew. · View Herald TranscriptDec 6 2024, 10:31 PM

Herald added a reviewer: manu. · View Herald Transcript

jhb requested review of this revision.Dec 6 2024, 10:31 PM

Harbormaster completed remote builds in B61002: Diff 147639.Dec 6 2024, 10:31 PM

jhb added a parent revision: D47960: Use the new bus_generic_detach directly in place of home-grown versions.Dec 6 2024, 10:31 PM

jhb added a child revision: D47962: Remove now-redundant calls to device_delete_children.

jhb accepted this revision.Jan 3 2025, 4:10 PM

jhb added a commit: rG4e62c3cafa4c: Remove now-redundant calls to device_delete_child.

This revision is now accepted and ready to land.Jan 3 2025, 4:10 PM

jhb closed this revision.Jan 3 2025, 4:10 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

if_emac.c

5 lines

dev/

ae/

if_ae.c

4 lines

age/

if_age.c

4 lines

alc/

if_alc.c

4 lines

ale/

if_ale.c

4 lines

dc/

if_dc.c

2 lines

dwc/

if_dwc.c

4 lines

eqos/

if_eqos.c

2 lines

et/

if_et.c

2 lines

fxp/

if_fxp.c

2 lines

ips/

ips.c

12 lines

jme/

if_jme.c

4 lines

msk/

if_msk.c

21 lines

nfe/

if_nfe.c

2 lines

nge/

if_nge.c

4 lines

pccbb/

pccbb.c

32 lines

re/

if_re.c

2 lines

rl/

if_rl.c

2 lines

sge/

if_sge.c

2 lines

sis/

if_sis.c

2 lines

sk/

if_sk.c

19 lines

smc/

if_smc.c

5 lines

ste/

if_ste.c

2 lines

stge/

if_stge.c

4 lines

vge/

if_vge.c

2 lines

vr/

if_vr.c

2 lines

vte/

if_vte.c

4 lines

xl/

if_xl.c

2 lines

Diff 147639

View Options

sys/arm/allwinner/if_emac.c

View Options

sys/dev/ae/if_ae.c

View Options

sys/dev/age/if_age.c

View Options

sys/dev/alc/if_alc.c

View Options

sys/dev/ale/if_ale.c

View Options

sys/dev/dc/if_dc.c

View Options

sys/dev/dwc/if_dwc.c

View Options

sys/dev/eqos/if_eqos.c

View Options

sys/dev/et/if_et.c

View Options

sys/dev/fxp/if_fxp.c

View Options

sys/dev/ips/ips.c

View Options

sys/dev/jme/if_jme.c

View Options

sys/dev/msk/if_msk.c

View Options

sys/dev/nfe/if_nfe.c

View Options

sys/dev/nge/if_nge.c

View Options

sys/dev/pccbb/pccbb.c

View Options

sys/dev/re/if_re.c

View Options

sys/dev/rl/if_rl.c

View Options

sys/dev/sge/if_sge.c

View Options

sys/dev/sis/if_sis.c

View Options

sys/dev/sk/if_sk.c

View Options

sys/dev/smc/if_smc.c

View Options

sys/dev/ste/if_ste.c

View Options

sys/dev/stge/if_stge.c

View Options

sys/dev/vge/if_vge.c

View Options

sys/dev/vr/if_vr.c

View Options

sys/dev/vte/if_vte.c

View Options

Remove now-redundant calls to device_delete_childClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147639

sys/arm/allwinner/if_emac.c

sys/dev/ae/if_ae.c

sys/dev/age/if_age.c

sys/dev/alc/if_alc.c

sys/dev/ale/if_ale.c

sys/dev/dc/if_dc.c

sys/dev/dwc/if_dwc.c

sys/dev/eqos/if_eqos.c

sys/dev/et/if_et.c

sys/dev/fxp/if_fxp.c

sys/dev/ips/ips.c

sys/dev/jme/if_jme.c

sys/dev/msk/if_msk.c

sys/dev/nfe/if_nfe.c

sys/dev/nge/if_nge.c

sys/dev/pccbb/pccbb.c

sys/dev/re/if_re.c

sys/dev/rl/if_rl.c

sys/dev/sge/if_sge.c

sys/dev/sis/if_sis.c

sys/dev/sk/if_sk.c

sys/dev/smc/if_smc.c

sys/dev/ste/if_ste.c

sys/dev/stge/if_stge.c

sys/dev/vge/if_vge.c

sys/dev/vr/if_vr.c

sys/dev/vte/if_vte.c

sys/dev/xl/if_xl.c

Remove now-redundant calls to device_delete_child
ClosedPublic
Actions

Revision Contents
Changeset List