inpcb: Make some cosmetic improvements to in_pcbbind()
ClosedPublic
Actions

Authored by markj on Nov 5 2024, 4:27 PM.

Details

Reviewers

Group Reviewers

Commits

rG906d603eeb50: inpcb: Make some cosmetic improvements to in_pcbbind()
rG45a77bf23fa2: inpcb: Make some cosmetic improvements to in_pcbbind()

Summary

Use the local var "laddr" instead of sin->sin_addr in one block.
Use in_nullhost() instead of explicit comparisons with INADDR_ANY.
Combine multiple socket options checks into one.
Fix indentation.
Remove some unhelpful comments.

This is in preparation for some simplification and bug-fixing.

No functional change intended.

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60403
Build 57287: arc lint + arc unit

Event Timeline

markj created this revision.Nov 5 2024, 4:27 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptNov 5 2024, 4:27 PM

markj requested review of this revision.Nov 5 2024, 4:27 PM

Harbormaster completed remote builds in B60403: Diff 146062.Nov 5 2024, 4:27 PM

glebius accepted this revision as: glebius.Nov 13 2024, 10:01 PM

This revision is now accepted and ready to land.Nov 13 2024, 10:01 PM

Closed by commit rG45a77bf23fa2: inpcb: Make some cosmetic improvements to in_pcbbind() (authored by markj). · Explain WhyNov 14 2024, 4:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG45a77bf23fa2: inpcb: Make some cosmetic improvements to in_pcbbind().

markj added a commit: rG906d603eeb50: inpcb: Make some cosmetic improvements to in_pcbbind().Thu, Nov 28, 2:41 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

44 lines

netinet6/

in6_pcb.c

19 lines

Diff 146062

View Options

sys/netinet/in_pcb.c