HomeFreeBSD

inpcb: Make some cosmetic improvements to in_pcbbind()

Description

inpcb: Make some cosmetic improvements to in_pcbbind()

  • Use the local var "laddr" instead of sin->sin_addr in one block.
  • Use in_nullhost() instead of explicit comparisons with INADDR_ANY.
  • Combine multiple socket options checks into one.
  • Fix indentation.
  • Remove some unhelpful comments.

This is in preparation for some simplification and bug-fixing.

No functional change intended.

Reviewed by: glebius
MFC after: 2 weeks
Sponsored by: Klara, Inc.
Sponsored by: Stormshield
Differential Revision: https://reviews.freebsd.org/D47451

(cherry picked from commit 45a77bf23fa2f36bf2169f7ba2a33b31f4c35adb)

Details

Provenance
markjAuthored on Thu, Nov 14, 4:05 PM
Reviewer
glebius
Differential Revision
D47451: inpcb: Make some cosmetic improvements to in_pcbbind()
Parents
rG34182e597b2a: swap_pager: Ensure that swapoff puts swapped-in pages in page queues
Branches
Unknown
Tags
Unknown