Page MenuHomeFreeBSD
Differential D47152

snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
ClosedPublic
Actions

Authored by christos on Oct 16 2024, 1:42 PM.
Tags
None
Referenced Files
F163304658: D47152.id.diff
Tue, Jul 21, 9:45 PM
F163240813: D47152.id144987.diff
Tue, Jul 21, 8:30 AM
F163234702: D47152.id145010.diff
Tue, Jul 21, 7:20 AM
Unknown Object (File)
Mon, Jul 20, 3:45 PM
Unknown Object (File)
Sun, Jul 19, 10:30 PM
Unknown Object (File)
Sat, Jul 18, 10:50 AM
Unknown Object (File)
Wed, Jul 8, 4:44 AM
Unknown Object (File)
Jun 4 2026, 1:12 AM
View All 97 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG867b2ee99995: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
rGde009cf68ba6: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Oct 16 2024, 1:42 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 16 2024, 1:42 PM
christos requested review of this revision.Oct 16 2024, 1:42 PM
Harbormaster completed remote builds in B60036: Diff 144987.Oct 16 2024, 1:42 PM
markj accepted this revision.Oct 16 2024, 1:46 PM
This revision is now accepted and ready to land.Oct 16 2024, 1:46 PM
emaste accepted this revision.Oct 16 2024, 6:38 PM

This is fine with me. There doesn't seem to be a consistent ordering here so it's not clear to me which one of the two is the "right" one to keep. It also looks like there are some additional duplicates.

sys/dev/sound/pci/hda/hdac.h
97–98

is this one also duplicated?

christos retitled this revision from snd_hda: Remove duplicate HDA_INTEL_CMLKLP entry to snd_hda: Remove duplicate HDA_INTEL_CMLK* entries.Oct 16 2024, 8:58 PM
christos updated this revision to Diff 145010.Oct 16 2024, 8:59 PM
christos marked an inline comment as done.

Remove CMLKH duplicate as well.

This revision now requires review to proceed.Oct 16 2024, 8:59 PM
Harbormaster completed remote builds in B60050: Diff 145010.Oct 16 2024, 8:59 PM
emaste accepted this revision.Oct 17 2024, 6:03 PM
This revision is now accepted and ready to land.Oct 17 2024, 6:03 PM
Closed by commit rGde009cf68ba6: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries (authored by christos). · Explain WhyOct 18 2024, 8:46 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGde009cf68ba6: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries.
christos added a commit: rG867b2ee99995: snd_hda: Remove duplicate HDA_INTEL_CMLK* entries.Oct 20 2024, 11:22 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
hda/
2 lines
2 lines

Diff 145096

View Options

sys/dev/sound/pci/hda/hdac.h

Loading...
View Options

sys/dev/sound/pci/hda/hdac.c

Loading...