This mirrors the equivalent option in GNU coreutils env, but does not
add support for long options.
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
0mp bcr - Group Reviewers
Klara - Commits
- rG6f6166e49c78: env: Add an option to change the directory.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 59848 Build 56733: arc lint + arc unit
Event Timeline
Comment Actions
We'll need to update the manual page as well. I could do that :)
| usr.bin/env/env.c | ||
|---|---|---|
| 72–73 | Any reason to keep it on one line? | |
| 96 | What happened here? | |
| 194 | Could we have it a bit more descriptive like "failed to change directory to %s" or something along those lines? Or does it attempt to follow what gnu env does? | |
| usr.bin/env/tests/env_test.sh | ||
| 125 | Could you also add a negative test? | |
| usr.bin/env/env.c | ||
|---|---|---|
| 96 | The strdup() is unnecessary and unchecked. I could either remove it or add a NULL check. Removing it was easier. | |