env: Add an option to change the directory.

[des]

Summary

This mirrors the equivalent option in GNU coreutils env, but does not
add support for long options.

Sponsored by: Klara, Inc.

[0mp]

We'll need to update the manual page as well. I could do that :)

usr.bin/env/env.c

72–73

Any reason to keep it on one line?

96

What happened here?

194

Could we have it a bit more descriptive like "failed to change directory to %s" or something along those lines? Or does it attempt to follow what gnu env does?

usr.bin/env/tests/env_test.sh

125

Could you also add a negative test?

[des]

incorporate review feedback

[0mp]

Thanks!

The manual page update and release notes may go in another revision.

[des]

Doh! The manual page had completely slipped my mind...

[des]

Update the manual page + error if -C or -P but no utility

[bcr]

OK for the man page change.

[0mp]

2 minor requests. Otherwise, the manual change looks OK.

usr.bin/env/env.1

516

-C should join this list. A note saying that it attempts to match GNU's behavior can be considered.

522

Would be nice to note what's the earliest release to feature -C.

[des]

man page tweaks

[des]

usr.bin/env/env.c

96

The strdup() is unnecessary and unchecked. I could either remove it or add a NULL check. Removing it was easier.

[0mp]

Thank you!