Page MenuHomeFreeBSD

CTL: add ATF tests for REPORT SUPPORTED OPCODES
ClosedPublic

Authored by asomers on Sep 9 2024, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 2:09 PM
Unknown Object (File)
Sat, Apr 18, 2:09 PM
Unknown Object (File)
Sat, Apr 18, 2:09 PM
Unknown Object (File)
Sat, Apr 18, 11:47 AM
Unknown Object (File)
Thu, Apr 9, 4:12 AM
Unknown Object (File)
Thu, Apr 2, 9:23 AM
Unknown Object (File)
Sun, Mar 22, 4:14 PM
Unknown Object (File)
Sun, Mar 22, 10:12 AM
Subscribers

Details

Summary

This includes a regression test for CVE-2024-42416

MFC after: 2 weeks
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59410
Build 56297: arc lint + arc unit

Event Timeline

Note that some of these tests, including the CVE-2024-4241 regression test, depend on a recent unreleased change in sg3_utils. For now, you can only get it by building sg3_utils from its git source.

I've avoided committing this so far because of the sg3_utils dependency. But I really don't want to leave it in Phabricator forever. Doug Gilbert is back at his keyboard again, and probably will release at some point. Shall I go ahead and commit now?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

I think that's overkill, given that some of the test cases don't need the newer version.

Do newly added tests report failure if sg3_utils is not updated?

Do newly added tests report failure if sg3_utils is not updated?

They'll check the version, and report "skipped" if it's too old.

Oh, in that case I think it's fine.

This revision is now accepted and ready to land.Tue, Apr 14, 1:57 PM