Page MenuHomeFreeBSD

CTL: add ATF tests for REPORT SUPPORTED OPCODES
ClosedPublic

Authored by asomers on Sep 9 2024, 7:21 PM.
Tags
None
Referenced Files
F165668016: D46613.diff
Sun, Aug 9, 2:55 AM
Unknown Object (File)
Sat, Aug 8, 5:43 PM
Unknown Object (File)
Sat, Aug 8, 5:20 AM
Unknown Object (File)
Mon, Aug 3, 8:05 PM
Unknown Object (File)
Mon, Aug 3, 1:37 AM
Unknown Object (File)
Sun, Aug 2, 6:26 AM
Unknown Object (File)
Fri, Jul 31, 2:13 AM
Unknown Object (File)
Tue, Jul 28, 2:34 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59410
Build 56297: arc lint + arc unit

Event Timeline

Note that some of these tests, including the CVE-2024-4241 regression test, depend on a recent unreleased change in sg3_utils. For now, you can only get it by building sg3_utils from its git source.

I've avoided committing this so far because of the sg3_utils dependency. But I really don't want to leave it in Phabricator forever. Doug Gilbert is back at his keyboard again, and probably will release at some point. Shall I go ahead and commit now?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

I think that's overkill, given that some of the test cases don't need the newer version.

Do newly added tests report failure if sg3_utils is not updated?

Do newly added tests report failure if sg3_utils is not updated?

They'll check the version, and report "skipped" if it's too old.

Oh, in that case I think it's fine.

This revision is now accepted and ready to land.Apr 14 2026, 1:57 PM