Page MenuHomeFreeBSD

CTL: add ATF tests for REPORT SUPPORTED OPCODES
ClosedPublic

Authored by asomers on Sep 9 2024, 7:21 PM.
Tags
None
Referenced Files
F168140644: D46613.id175516.diff
Wed, Aug 26, 1:47 PM
F167979613: D46613.id143154.diff
Tue, Aug 25, 5:47 PM
Unknown Object (File)
Fri, Aug 21, 3:52 AM
Unknown Object (File)
Wed, Aug 19, 2:07 AM
Unknown Object (File)
Sat, Aug 15, 11:06 AM
Unknown Object (File)
Thu, Aug 13, 12:19 AM
Unknown Object (File)
Mon, Aug 10, 12:47 PM
Unknown Object (File)
Sun, Aug 9, 2:55 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Note that some of these tests, including the CVE-2024-4241 regression test, depend on a recent unreleased change in sg3_utils. For now, you can only get it by building sg3_utils from its git source.

I've avoided committing this so far because of the sg3_utils dependency. But I really don't want to leave it in Phabricator forever. Doug Gilbert is back at his keyboard again, and probably will release at some point. Shall I go ahead and commit now?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

I think that's overkill, given that some of the test cases don't need the newer version.

Do newly added tests report failure if sg3_utils is not updated?

Do newly added tests report failure if sg3_utils is not updated?

They'll check the version, and report "skipped" if it's too old.

Oh, in that case I think it's fine.

This revision is now accepted and ready to land.Apr 14 2026, 1:57 PM