Page MenuHomeFreeBSD

CTL: add ATF tests for REPORT SUPPORTED OPCODES
ClosedPublic

Authored by asomers on Sep 9 2024, 7:21 PM.
Tags
None
Referenced Files
F156658318: D46613.id.diff
Fri, May 15, 11:28 AM
F156658288: D46613.id.diff
Fri, May 15, 11:28 AM
F156600222: D46613.id175516.diff
Fri, May 15, 12:35 AM
F156561088: D46613.id143154.diff
Thu, May 14, 4:34 PM
Unknown Object (File)
Mon, May 11, 7:49 PM
Unknown Object (File)
Sun, May 3, 9:49 PM
Unknown Object (File)
Sun, May 3, 4:31 AM
Unknown Object (File)
Sun, May 3, 1:26 AM
Subscribers

Details

Summary

This includes a regression test for CVE-2024-42416

MFC after: 2 weeks
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Note that some of these tests, including the CVE-2024-4241 regression test, depend on a recent unreleased change in sg3_utils. For now, you can only get it by building sg3_utils from its git source.

I've avoided committing this so far because of the sg3_utils dependency. But I really don't want to leave it in Phabricator forever. Doug Gilbert is back at his keyboard again, and probably will release at some point. Shall I go ahead and commit now?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

How about commenting out the Makefile change for now with a comment about needing newer sg3_utils?

I think that's overkill, given that some of the test cases don't need the newer version.

Do newly added tests report failure if sg3_utils is not updated?

Do newly added tests report failure if sg3_utils is not updated?

They'll check the version, and report "skipped" if it's too old.

Oh, in that case I think it's fine.

This revision is now accepted and ready to land.Apr 14 2026, 1:57 PM