pfctl: fix incorrect optimization
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:34 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG637d81c52d21: pfctl: fix incorrect optimization

Summary

In the non-optimized case, an address list containing "any" (ie. { any 10.0.0.1 })
should be folded in the parser to any, not to 10.0.0.1. How long this bug has
been with us is unclear.
ok guenther mcbride

Obtained from: OpenBSD, deraadt <deraadt@openbsd.org>, e3b4bc25a0
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59368
Build 56255: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:34 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 7 2024, 9:34 AM

kp requested review of this revision.Sep 7 2024, 9:34 AM

Harbormaster completed remote builds in B59368: Diff 143076.Sep 7 2024, 9:34 AM

kp added a parent revision: D46579: pf.conf.5: document received-on.Sep 7 2024, 9:34 AM

kp added a child revision: D46581: pf tests: ensure we correctly optimize { any, 192.0.2.3 }.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2024, 1:06 PM

Closed by commit rG637d81c52d21: pfctl: fix incorrect optimization (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG637d81c52d21: pfctl: fix incorrect optimization.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

parse.y

14 lines

pfctl_parser.h

2 lines

Diff 143076

View Options

sbin/pfctl/parse.y