Page MenuHomeFreeBSD
Differential D45341

bhyve: add interface to protect BAR regions of passthru devices
Needs ReviewPublic
Actions

Authored by corvink on May 24 2024, 11:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 1:32 AM
Unknown Object (File)
Sat, Apr 5, 9:32 AM
Unknown Object (File)
Sat, Mar 22, 5:21 AM
Unknown Object (File)
Mar 3 2025, 1:13 AM
Unknown Object (File)
Feb 8 2025, 2:50 AM
Unknown Object (File)
Jan 29 2025, 9:18 AM
Unknown Object (File)
Dec 3 2024, 8:59 AM
Unknown Object (File)
Nov 13 2024, 6:17 PM
View All 32 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Summary

We need an interface for protecting BAR regions to make it easier to use this
feature and to make it usable by external emulations like the GVT-d emulation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57897
Build 54785: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines
39 lines

Diff 139038

View Options

usr.sbin/bhyve/pci_passthru.h

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Linesint passthru_cfgread_emulate(struct passthru_softc *sc, struct pci_devinst *pi,
int coff, int bytes, uint32_t *rv); int coff, int bytes, uint32_t *rv);
int passthru_cfgwrite_emulate(struct passthru_softc *sc, struct pci_devinst *pi, int passthru_cfgwrite_emulate(struct passthru_softc *sc, struct pci_devinst *pi,
int coff, int bytes, uint32_t val); int coff, int bytes, uint32_t val);
struct passthru_mmio_mapping *passthru_get_mmio(struct passthru_softc *sc, struct passthru_mmio_mapping *passthru_get_mmio(struct passthru_softc *sc,
int num); int num);
struct pcisel *passthru_get_sel(struct passthru_softc *sc); struct pcisel *passthru_get_sel(struct passthru_softc *sc);
int set_pcir_handler(struct passthru_softc *sc, int reg, int len, int set_pcir_handler(struct passthru_softc *sc, int reg, int len,
cfgread_handler rhandler, cfgwrite_handler whandler); cfgread_handler rhandler, cfgwrite_handler whandler);
int passthru_set_bar_handler(struct passthru_softc *sc, int baridx,
vm_offset_t off, vm_size_t len, passthru_read_handler rhandler,
passthru_write_handler whandler);
View Options

usr.sbin/bhyve/pci_passthru.c

Show First 20 Lines • Show All 704 Lines • ▼ Show 20 Lines for (int i = reg; i < reg + len; ++i) {
assert(sc->psc_pcir_whandler[i] == NULL || whandler == NULL); assert(sc->psc_pcir_whandler[i] == NULL || whandler == NULL);
sc->psc_pcir_rhandler[i] = rhandler; sc->psc_pcir_rhandler[i] = rhandler;
sc->psc_pcir_whandler[i] = whandler; sc->psc_pcir_whandler[i] = whandler;
} }
return (0); return (0);
} }
int
passthru_set_bar_handler(struct passthru_softc *sc, int baridx, vm_offset_t off,
vm_size_t len, passthru_read_handler rhandler,
passthru_write_handler whandler)
{
struct passthru_bar_handler *handler_new;
struct passthru_bar_handler *handler;
assert(sc->psc_bar[baridx].type == PCIBAR_IO ||
sc->psc_bar[baridx].type == PCIBAR_MEM32 ||
sc->psc_bar[baridx].type == PCIBAR_MEM64);
assert(sc->psc_bar[baridx].size > off + len);
assert(off < off + len);
handler_new = malloc(sizeof(struct passthru_bar_handler));
if (handler_new == NULL) {
return (ENOMEM);
}
handler_new->off = off;
handler_new->len = len;
handler_new->read = rhandler;
handler_new->write = whandler;
TAILQ_FOREACH (handler, &sc->psc_bar_handler[baridx], chain) {
if (handler->off < handler_new->off) {
assert(handler->off + handler->len < handler_new->off);
continue;
}
assert(handler->off > handler_new->off + handler_new->len);
TAILQ_INSERT_BEFORE(handler, handler_new, chain);
return (0);
}
TAILQ_INSERT_TAIL(&sc->psc_bar_handler[baridx], handler_new, chain);
return (0);
}
static int static int
passthru_legacy_config(nvlist_t *nvl, const char *opts) passthru_legacy_config(nvlist_t *nvl, const char *opts)
{ {
const char *cp; const char *cp;
char *tofree; char *tofree;
char value[16]; char value[16];
int bus, slot, func; int bus, slot, func;
▲ Show 20 Lines • Show All 657 Lines • Show Last 20 Lines