Page MenuHomeFreeBSD
Differential D45085

vm: simplify conditional for dumping startup pages
ClosedPublic
Actions

Authored by bnovkov on May 3 2024, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 11:23 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Fri, Mar 14, 6:29 AM
Unknown Object (File)
Thu, Mar 13, 12:08 AM
Unknown Object (File)
Wed, Feb 26, 1:42 PM
Unknown Object (File)
Feb 10 2025, 12:34 PM
Unknown Object (File)
Feb 9 2025, 1:15 AM
Unknown Object (File)
Feb 7 2025, 11:54 PM
View All 68 Files
Subscribers
emaste
imp
jhibbits
riscv

Details

Reviewers
markj
mhorne
andrew
manu
Commits
rG0a44b8a56d23: vm: Simplify startup page dumping conditional
Summary

This patch introduces the MINIDUMP_STARTUP_PAGE_TRACKING symbol and uses it to simplify several instances of a complex check for adding startup pages to minidumps.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bnovkov created this revision.May 3 2024, 8:26 PM
Herald added a reviewer: andrew. · View Herald TranscriptMay 3 2024, 8:26 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript
bnovkov requested review of this revision.May 3 2024, 8:26 PM
bnovkov added a child revision: D45044: uma: retire UMA_MD_SMALL_ALLOC.May 3 2024, 8:31 PM
mhorne added a comment.EditedMay 6 2024, 5:41 PM

Thanks for this. Seems good to me, with one question inline.

Edit: you missed the update of vmparam.h for 32-bit arm.

sys/vm/vm_page.c
623

Why is this condition different than the others?

bnovkov updated this revision to Diff 138260.May 8 2024, 4:50 PM

Add missing arm vmparam.h updates.

bnovkov added inline comments.May 8 2024, 4:55 PM
sys/vm/vm_page.c
623

I wanted to avoid adding another #if MINIDUMP_PAGE_TRACKING && MINIDUMP_STARTUP_PAGE_TRACKING, so I've moved the #if MINIDUMP_STARTUP_PAGE_TRACKING block under the MINIDUMP_PAGE_TRACKING block defined on line 598.

The condition is still the same, but less verbose.

mhorne accepted this revision.May 9 2024, 5:07 PM
mhorne added inline comments.
sys/vm/vm_page.c
623

Thanks, I see now.

This revision is now accepted and ready to land.May 9 2024, 5:07 PM
markj accepted this revision.May 13 2024, 1:14 PM
Closed by commit rG0a44b8a56d23: vm: Simplify startup page dumping conditional (authored by bnovkov). · Explain WhyMay 25 2024, 5:25 PM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rG0a44b8a56d23: vm: Simplify startup page dumping conditional.

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
3 lines
arm/
include/
1 line
arm64/
include/
1 line
i386/
include/
1 line
powerpc/
include/
2 lines
riscv/
include/
1 line
vm/
6 lines
12 lines

Diff 138260

View Options

sys/amd64/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/arm/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/arm64/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/i386/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/powerpc/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/riscv/include/vmparam.h

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines if (ACPI_FAILURE(status))
return (status); return (status);
status = AE_TYPE; status = AE_TYPE;
obj = (ACPI_OBJECT *)buf.Pointer; obj = (ACPI_OBJECT *)buf.Pointer;
if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) { if (obj->Type == ACPI_TYPE_PACKAGE && obj->Package.Count == 3) {
elems = obj->Package.Elements; elems = obj->Package.Elements;
*scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_hcnt = elems[0].Integer.Value & IG4_SCL_CLOCK_MASK;
*scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK; *scl_lcnt = elems[1].Integer.Value & IG4_SCL_CLOCK_MASK;
if (elems[2].Integer.Value != 0) {
/*
* If the value in the table is zero, stick
* with value calculated earlier for sda_hold.
*/
*sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK; *sda_hold = elems[2].Integer.Value & IG4_SDA_TX_HOLD_MASK;
}
status = AE_OK; status = AE_OK;
} }
AcpiOsFree(obj); AcpiOsFree(obj);
return (status); return (status);
} }
#endif /* DEV_ACPI */ #endif /* DEV_ACPI */
▲ Show 20 Lines • Show All 403 Lines • Show Last 20 Lines
View Options

sys/vm/uma_core.c

Loading...
View Options

sys/vm/vm_page.c

Loading...