Page MenuHomeFreeBSD
Differential D45014

sound: Use nitems() where possible
ClosedPublic
Actions

Authored by christos on Apr 29 2024, 4:22 PM.
Tags
None
Referenced Files
F153301870: D45014.id138178.diff
Mon, Apr 20, 8:35 AM
Unknown Object (File)
Tue, Apr 7, 9:44 AM
Unknown Object (File)
Mon, Apr 6, 8:05 AM
Unknown Object (File)
Mar 8 2026, 11:03 AM
Unknown Object (File)
Mar 8 2026, 4:04 AM
Unknown Object (File)
Mar 6 2026, 10:41 AM
Unknown Object (File)
Mar 4 2026, 6:23 PM
Unknown Object (File)
Feb 8 2026, 2:19 PM
View All 73 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG00b0cbf98bb7: sound: Use nitems() where possible
rGc597c5579232: sound: Use nitems() where possible
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57449
Build 54337: arc lint + arc unit

Event Timeline

christos created this revision.Apr 29 2024, 4:22 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 29 2024, 4:22 PM
christos requested review of this revision.Apr 29 2024, 4:22 PM
Harbormaster completed remote builds in B57449: Diff 137847.Apr 29 2024, 4:22 PM
emaste accepted this revision.Apr 29 2024, 5:12 PM
emaste added inline comments.
sys/dev/sound/pcm/feeder_format.c
124

this could be updated to size_t while here

276

and here

289

and here

This revision is now accepted and ready to land.Apr 29 2024, 5:12 PM
markj accepted this revision.Apr 30 2024, 12:10 AM

Indeed, it's nicer to use unsigned types (unsigned int or size_t) for comparisons with nitems().

christos marked 3 inline comments as done.Apr 30 2024, 12:30 AM
Closed by commit rGc597c5579232: sound: Use nitems() where possible (authored by christos). · Explain WhyMay 6 2024, 6:38 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGc597c5579232: sound: Use nitems() where possible.
christos added a commit: rG00b0cbf98bb7: sound: Use nitems() where possible.May 17 2024, 7:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
2 lines
hda/
2 lines
2 lines
4 lines
pcm/
9 lines
4 lines
2 lines
2 lines
2 lines

Diff 137847

View Options

sys/dev/sound/pci/atiixp.c

Loading...
View Options

sys/dev/sound/pci/hda/hdaa.c

Loading...
View Options

sys/dev/sound/pci/ich.c

Loading...
View Options

sys/dev/sound/pci/maestro3.c

Loading...
View Options

sys/dev/sound/pcm/feeder_format.c

Loading...
View Options

sys/dev/sound/pcm/feeder_matrix.c

Loading...
View Options

sys/dev/sound/pcm/feeder_volume.c

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...