guestrpc module to handle VMware backdoor port GuestRPC functionality
ClosedPublic
Actions

Authored by stevek on Mar 27 2024, 3:18 PM.

Details

Reviewers

jhb

Commits

rGecaab0fb5da4: guestrpc module to handle VMware backdoor port GuestRPC functionality

Summary

Convert existing FreeBSD vmware_hvcall function to take a channel
and parameter arguments.

Added vmware_guestrpc_cmd() to send GuestRPC commands to the VMware
hypervisor. The sbuf argument is used for both the command to send
and to store the data to return to the caller.

The following KPIs can be used to get and set FreeBSD-specific guest
information in key/value pairs:

vmware_guestrpc_set_guestinfo
- set a value into the guestinfo.fbsd.<keyword> key
vmware_guestrpc_get_guestinfo
- get the value stored in the guestinfo.fbsd.<keyword> key

Add VMware devices to x86 NOTES

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57333
Build 54221: arc lint + arc unit

Event Timeline

stevek created this revision.Mar 27 2024, 3:18 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 27 2024, 3:18 PM

stevek requested review of this revision.Mar 27 2024, 3:18 PM

Harbormaster completed remote builds in B56802: Diff 136272.Mar 27 2024, 3:18 PM

Fixed typo in comment.

Harbormaster completed remote builds in B56803: Diff 136273.Mar 27 2024, 3:20 PM

A few small suggestions and nits, but looks great to me overall.

sys/amd64/conf/NOTES
516 ↗	(On Diff #136273)	Should this be in sys/x86/conf/NOTES instead?
520 ↗	(On Diff #136273)	vmx is already in both the i386 and amd64 NOTES files
sys/conf/files.amd64
442 ↗	(On Diff #136273)	Maybe add this in sys/conf/files.x86 instead since it is the same in both files?
sys/x86/include/vmware.h
36	Does it make sense to define a `VMW_HVCMD_DEFAULT_PARAM` or some such that is `UINT_MAX` that existing commands should use? That might be more readable to others in the future.
sys/x86/include/vmware_guestrpc.h
2–4	Is Juniper ok with dropping the "All rights reserved." line? The project prefers not using this for new files (and removing it when licensees agree to do so even).
sys/x86/x86/vmware_guestrpc.c
103	style(9) wants ()'s around return values. Most places in this file already do this, but a few do not.

stevek added inline comments.Apr 12 2024, 10:05 PM

sys/amd64/conf/NOTES
516 ↗	(On Diff #136273)	Yes, I think you are correct.
sys/x86/include/vmware.h
36	Yes, that would be a good idea.
sys/x86/include/vmware_guestrpc.h
2–4	Yes, that would be fine.