Add sys/errno.h, sys/malloc.h, and vm/uma.h as needed.
sysproto.h currently includes sys/acl.h which currently includes
sys/param.h, sys/queue.h, and vm/uma.h which in turn bring in
sys/errno.h sys/malloc.h.
Details
Details
- Reviewers
kib imp trasz - Commits
- rG6bb132ba1e4e: Reduce reliance on sys/sysproto.h pollution
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 56742 Build 53630: arc lint + arc unit
Event Timeline
Comment Actions
This review stack is the result of trying to remove sys/acl.h from sys/sysproto.h after 27676ae365f62c22f8daa816bf7a07d22bd081d9 and discovering that there were a lot of things that depended on its header pollution.
| sys/kern/kern_time.c | ||
|---|---|---|
| 40 | This is excessive. Or, at least in other places, the patch depends on vm/uma.h including sys/malloc.h. | |
Comment Actions
- Add a sys/queue.h include after _KERNEL ifdef of sys/malloc.h in sys/acl.h
- Explain sys/malloc.h include in kern_time.c
| sys/kern/kern_time.c | ||
|---|---|---|
| 40 | It took a little poking around, but it turns out we need sys/malloc.h before sys/proc.h for the M_ macros we need to be declared. Arguably that's a bug in sys/proc.h. | |
| sys/kern/kern_time.c | ||
|---|---|---|
| 40 | The proc.h M_ declarations are under the #ifdef brace. I suspect they could be moved to sys/malloc.h without much hassle. | |