- provided OFW interface for pci_host_generic (for handling devices which are present in DTS under the PCI node)
- removed support for internal pci from qrm64/cavium
- cleaned up and made most of the code common
Details
Details
- Reviewers
zbb br - Commits
- rS295962: Make pci_host_generic and thunderx_pci common
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/dev/pci/pci_host_generic.c | ||
|---|---|---|
| 153 | struct generic_pcie_quirks *quirk; | |
Comment Actions
Moved qiurk to machine-specific file as suggested by cognet. Also, cleaned up a little and changed bus_probe to be GENERIC.
| sys/dev/pci/pci_host_generic.c | ||
|---|---|---|
| 94 | will be removed | |
Comment Actions
Actually, there is one in sys/dev/pci/pci_host_generic.c:232. The generic driver must know the machine-dependent domain (ECAM number) it operates on.
Comment Actions
In that case I think it would make sense to create a sub class of the generic driver to handle the ThunderX specific changes.
| sys/dev/pci/pci_host_generic.c | ||
|---|---|---|
| 171 | This whole file is meant to be used when FDT is enabled. Are you suggesting surrounding this part with ifdef FDT? Or did you have something else in mind? | |
| 629 | I don't want to mix the code for pci and ofw allocation, it'd make the functions too long, hard to read and to maintain. I'm using the same pattern here as in old thunder_pcie.c. | |