libcxxrt: don't export nonexistant symbols
ClosedPublic
Actions

Authored by brooks on Mar 12 2024, 9:15 PM.

Details

Reviewers

emaste
dim
theraven
andrew

Commits

rGda77a1b4f0df: libcxxrt: don't export nonexistant symbols

Summary

Remove version entries that we don't build.

Add an arm specific Version.map and for other targets run the files
through sed to handle int vs long in new and delete.

Ideally we'd use the SYMBOL_MAPS functionality to preproces with cpp,
but it doesn't currently handle C++ symbols so be annoyingly duplicative
for now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56560
Build 53448: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 12 2024, 9:15 PM

Herald added a reviewer: andrew. · View Herald TranscriptMar 12 2024, 9:15 PM

Herald added a subscriber: imp. · View Herald Transcript

brooks requested review of this revision.Mar 12 2024, 9:15 PM

Harbormaster completed remote builds in B56560: Diff 135666.Mar 12 2024, 9:15 PM

brooks added a child revision: D44216: Make WITHOUT_UNDEFINED_VERSION the default.Mar 12 2024, 9:15 PM

These changes to Version.map aren't optimal, but they work in that they allow building with WITHOUT_UNDEFINED_VERSION defined and I've used my symbol level ABI checker (D44271) to verify that no symbols were lost.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2024, 9:15 PM

Closed by commit rGda77a1b4f0df: libcxxrt: don't export nonexistant symbols (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGda77a1b4f0df: libcxxrt: don't export nonexistant symbols.