x86/xen: fix migration when ACPI suspend is not available
ClosedPublic
Actions

Authored by royger on Feb 6 2024, 8:43 AM.

Details

Reviewers

kib
cem
markj
jhb

Commits

rGe7e2431586a4: x86/xen: fix migration when ACPI suspend is not available

Summary

Xen PVH guests expose a very minimal set of ACPI tables, and due to the lack of
SCI interrupt FreeBSD doesn't allocate the suspend stacks for saving for CPU
and FPU contexts.

Such lack of context would lead to a page-fault in cpususpend_handler() when
CPUs attempted to use the save context area as a result of a Xen suspend
request. However there's no need to save the CPU or the FPU registers in the
Xen case, as that's all handled by the hypervisor. Hence avoid saving all this
state if the suspend stacks are not allocated.

Note that this will currently only apply to PVH guests, HVM ones will still get
the stack allocated and the context saved even when not strictly required. I
find it easier rather that having to provide cpususpend_handler() with extra
information whether the context needs to be saved or not.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

royger created this revision.Feb 6 2024, 8:43 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2024, 8:43 AM

royger requested review of this revision.Feb 6 2024, 8:43 AM

markj added inline comments.Feb 6 2024, 3:59 PM

sys/x86/x86/mp_x86.c
1600	I think a comment summarizing the commit message would be helpful here.

Add comment.

royger marked an inline comment as done.Feb 6 2024, 5:22 PM

royger added inline comments.

sys/x86/x86/mp_x86.c
1600	I wonder whether I should add some ASSERT here that we are at least running as a Xen guest, but that would require including `xen-os.h` header to this otherwise common file.