HomeFreeBSD

x86/xen: fix migration when ACPI suspend is not available

Description

x86/xen: fix migration when ACPI suspend is not available

Xen PVH guests expose a very minimal set of ACPI tables, and due to the lack of
SCI interrupt FreeBSD doesn't allocate the suspend stacks for saving CPU and
FPU contexts.

Lack of allocated stacks would lead to a page-fault in cpususpend_handler() when
CPUs attempted to use the save context area as a result of a Xen suspend
request. However there's no need to save the CPU or the FPU registers in the
Xen case, as that's all handled by the hypervisor. Hence avoid saving all this
state if the suspend stacks are not allocated.

Note that this will currently only apply to PVH guests, HVM ones will still get
the stack allocated and the context saved even when not strictly required. I
find it easier rather that having to provide cpususpend_handler() with extra
information whether the context needs to be saved or not.

Sponsored by: Cloud Software Group
Reviewed by: markj
Differential revision: https://reviews.freebsd.org/D43765

Details

Provenance
roygerAuthored on Feb 6 2024, 8:16 AM
Reviewer
markj
Differential Revision
D43765: x86/xen: fix migration when ACPI suspend is not available
Parents
rG17d5b027c192: md5: Clean up input stream rights.
Branches
Unknown
Tags
Unknown