Files loaded "-t firmware" (or module_type="firmware"). They are
registered with the firmware system using the full path to allow
the drivers to find them. There's only one firmware per file, and it is the
entire file.
Sponsored by: Netflix
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 55808 Build 52697: arc lint + arc unit
Event Timeline
Comment Actions
Unsure. I'll have to poke a bit. I had the same thought but wanted to get this in to see how hard it was and how well it worked.
Ideally, though, the driver would just do firmware_get like it does today and we'd load it in from some path automatically. Maybe with some mapping file, but likely not. Likely with a sane path like we have for .ko.
Comment Actions
I also still prefer double spaces after periods in monospace text (code comments).
| sys/kern/subr_firmware.c | ||
|---|---|---|
| 592 | ||
| 604–608 | I like your approach from your kldxref patch here better as it avoids the magic number of 4 all over. That is: char *t;
....
t = strrchr(name, '.');
if (t != NULL && strcmp(t, ".bin") == 0)
*t = '\0'; | |
Comment Actions
Change around a little how we're loading. Save the full filename and allow
subpath searches to succeed.
| sys/kern/subr_firmware.c | ||
|---|---|---|
| 571 | I think I'm going to change this to 'native' since 'native format' is defined by the creating application (in this case the hardware the firmware is for). | |
Comment Actions
If you do need the relative name lookups with some path components, then this is ok as-is to me.
| sys/kern/subr_firmware.c | ||
|---|---|---|
| 165 | Do you want to fix this when registering the file instead? That is, only register the last component of the filename down in firmware_binary_files() instead? Oh, or are there requests that actually use partial paths? If so, I guess you have to do it this way. | |
| sys/kern/subr_firmware.c | ||
|---|---|---|
| 165 | There are requests with partial paths, though they often do other lookups w/o the path. I think the safest way is to match like this, but if it causes grief later, we can shift. I'm not sure that doing it at load time would suffice... For example, rtw88 looks up rtw88/rtw8821c_fw.bin and then rtw8821c_fw.bin and then rtw88_rtw8821c_fw.bin and a few others. | |
| sys/kern/subr_firmware.c | ||
|---|---|---|
| 165 | Also if i load /boot/precious/onering-fw.bin then i want that to work regardless of load path... | |