Tags

None

Referenced Files

	F86118849: D43607.id133371.diff
	Sat, Jun 15, 6:05 PM

	Unknown Object (File)
	Sun, May 26, 1:22 PM

	Unknown Object (File)
	Wed, May 22, 1:20 PM

	Unknown Object (File)
	May 9 2024, 5:31 PM

	Unknown Object (File)
	May 9 2024, 8:24 AM

	Unknown Object (File)
	May 3 2024, 8:49 AM

	Unknown Object (File)
	Apr 27 2024, 10:52 PM

	Unknown Object (File)
	Apr 27 2024, 10:52 PM

Subscribers

Details

Reviewers

imp
chuck
corvink

Group Reviewers

bhyve

Commits

rGc46860dbcb20: bhyve: Use NVMEF macro to construct fields

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 25 2024, 10:29 PM

Herald added a reviewer: bhyve. · View Herald TranscriptJan 25 2024, 10:29 PM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

jhb requested review of this revision.Jan 25 2024, 10:29 PM

Harbormaster completed remote builds in B55621: Diff 133371.Jan 25 2024, 10:29 PM

jhb added a parent revision: D43606: nvmecontrol: Use NVMEF macro to construct fields.Jan 25 2024, 10:29 PM

jhb added a reviewer: chuck.Jan 25 2024, 10:31 PM

corvink accepted this revision.Jan 26 2024, 7:47 AM

This revision is now accepted and ready to land.Jan 26 2024, 7:47 AM

jhb added inline comments.Jan 26 2024, 10:39 PM

usr.sbin/bhyve/pci_nvme.c
2082–2083	This hunk belongs in D43600 instead. It's just a less typical way of spelling it.

chuck accepted this revision.Jan 28 2024, 1:07 AM

Closed by commit rGc46860dbcb20: bhyve: Use NVMEF macro to construct fields (authored by jhb). · Explain WhyJan 29 2024, 7:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc46860dbcb20: bhyve: Use NVMEF macro to construct fields.

bhyve: Use NVMEF macro to construct fields
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 133526

usr.sbin/bhyve/pci_nvme.c

bhyve: Use NVMEF macro to construct fieldsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 133526

usr.sbin/bhyve/pci_nvme.c

bhyve: Use NVMEF macro to construct fields
ClosedPublic
Actions

Revision Contents
Changeset List