Page MenuHomeFreeBSD
Differential D40347

login.conf(5): Default values: Rename column, elaborate on absence of such
ClosedPublic
Actions

Authored by olce on May 31 2023, 2:35 PM.
Tags
None
Referenced Files
F164591641: D40347.id122654.diff
Sun, Aug 2, 6:02 AM
F164586100: D40347.id123006.diff
Sun, Aug 2, 5:28 AM
F164563697: D40347.id123598.diff
Sun, Aug 2, 2:58 AM
F164561247: D40347.id133403.diff
Sun, Aug 2, 2:41 AM
F164555233: D40347.id133404.diff
Sun, Aug 2, 1:56 AM
Unknown Object (File)
Sat, Aug 1, 8:31 AM
Unknown Object (File)
Fri, Jul 31, 8:28 PM
Unknown Object (File)
Wed, Jul 29, 11:06 PM
View All Files
Subscribers
andrew_tao173.riddles.org.uk
emaste
imp

Details

Reviewers
kib
mjg
yuripv
kevans
des
emaste
Commits
rG63c3be3b4f4b: login.conf(5): Default values: Rename column, elaborate on absence of such
rG8f4c3ef048e3: login.conf(5): Default values: Rename column, elaborate on absence of such
rG92b2c4358f57: login.conf(5): Default values: Rename column, elaborate on absence of such
Summary

Column "Notes" in fact only contains default values for capabilities, so
make this clear by renaming it to "Default".

Add a small introductory text mentioning it, and what an absence of
default value means (inheritance).

PR: 271748

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55643
Build 52532: arc lint + arc unit

Event Timeline

olce created this revision.May 31 2023, 2:35 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2023, 2:35 PM
olce requested review of this revision.May 31 2023, 2:35 PM
Harbormaster completed remote builds in B51799: Diff 122654.May 31 2023, 2:35 PM
olce added a parent revision: D40346: setlogincontext(): Comply to style(9).May 31 2023, 3:16 PM
olce added a child revision: D40349: setusercontext(): Better error messages when priority is not set correctly.May 31 2023, 3:19 PM
olce added reviewers: kib, mjg, yuripv, kevans, des.Jun 6 2023, 8:26 AM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJun 6 2023, 8:26 AM
olce updated this revision to Diff 123006.Jun 9 2023, 2:42 PM
olce edited the summary of this revision. (Show Details)

Add PR in commit message. Fix typo (section is name "Default").

Harbormaster completed remote builds in B51980: Diff 123006.Jun 9 2023, 2:42 PM
olce updated this revision to Diff 123598.Jun 21 2023, 1:43 PM

Refresh

Harbormaster completed remote builds in B52221: Diff 123598.Jun 21 2023, 1:43 PM
emaste accepted this revision.Jan 26 2024, 2:33 PM
emaste added a subscriber: emaste.

In the commit message I'd add some comment that a column for defaults already existed, it just had the wrong name.

lib/libutil/login.conf.5
185

"in the" or "by the" Default column sounds more natural

188

A little less verbose perhaps, "If there is no default, the value is inherited from..."

This revision is now accepted and ready to land.Jan 26 2024, 2:33 PM
olce updated this revision to Diff 133403.Jan 26 2024, 3:12 PM
olce marked 2 inline comments as done.
olce retitled this revision from login.conf(5): Default values under "Default", elaborate on absence of such to login.conf(5): Default values: Rename column, elaborate on absence of such.
olce edited the summary of this revision. (Show Details)

Apply suggestions.

This revision now requires review to proceed.Jan 26 2024, 3:12 PM
Harbormaster completed remote builds in B55642: Diff 133403.Jan 26 2024, 3:12 PM
olce updated this revision to Diff 133404.Jan 26 2024, 3:18 PM
olce edited the summary of this revision. (Show Details)

Fix the commit message.

Harbormaster completed remote builds in B55643: Diff 133404.Jan 26 2024, 3:18 PM
emaste accepted this revision.Jan 26 2024, 3:30 PM
This revision is now accepted and ready to land.Jan 26 2024, 3:30 PM
Closed by commit rG92b2c4358f57: login.conf(5): Default values: Rename column, elaborate on absence of such (authored by olce). · Explain WhyJan 29 2024, 10:32 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG92b2c4358f57: login.conf(5): Default values: Rename column, elaborate on absence of such.
olce added a commit: rG8f4c3ef048e3: login.conf(5): Default values: Rename column, elaborate on absence of such.Feb 1 2024, 9:26 PM
olce added a commit: rG63c3be3b4f4b: login.conf(5): Default values: Rename column, elaborate on absence of such.Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
14 lines

Diff 133404

View Options

lib/libutil/login.conf.5

Loading...