Page MenuHomeFreeBSD

libc: Purge unneeded cdefs.h
ClosedPublic

Authored by imp on Oct 27 2023, 10:42 PM.
Tags
None
Referenced Files
F142617903: D42385.id130790.largetrue.diff
Wed, Jan 21, 1:25 PM
Unknown Object (File)
Tue, Jan 20, 12:30 PM
Unknown Object (File)
Mon, Jan 19, 7:32 PM
Unknown Object (File)
Mon, Jan 19, 7:29 PM
Unknown Object (File)
Mon, Jan 19, 6:35 PM
Unknown Object (File)
Mon, Jan 19, 1:27 PM
Unknown Object (File)
Mon, Jan 19, 12:13 PM
Unknown Object (File)
Mon, Jan 19, 11:47 AM
Subscribers

Details

Summary

These sys/cdefs.h are not needed. Purge them. They are mostly left-over
from the $FreeBSD$ removal. A few in libc are still required for macros
that cdefs.h defines. Keep those.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54193
Build 51083: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 27 2023, 10:42 PM

applied to my local tree I see:

--- i386_get_ldt.o ---
In file included from /tmp/cirrus-ci-build/lib/libc/i386/sys/i386_get_ldt.c:31:
In file included from /usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/machine/segments.h:39:
In file included from /usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/i386/segments.h:46:
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/x86/segments.h:88:3: error: redefinition of '__packed' with a different type: 'struct user_segment_descriptor' vs 'struct segment_descriptor'
} __packed;
  ^
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/x86/segments.h:74:3: note: previous definition is here
} __packed;
  ^
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/x86/segments.h:110:3: error: redefinition of '__packed' with a different type: 'struct gate_descriptor' vs 'struct segment_descriptor'
} __packed;
  ^
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/x86/segments.h:74:3: note: previous definition is here
} __packed;
  ^
In file included from /tmp/cirrus-ci-build/lib/libc/i386/sys/i386_get_ldt.c:31:
In file included from /usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/machine/segments.h:39:
/usr/obj/tmp/cirrus-ci-build/amd64.amd64/sysroot/usr/include/i386/segments.h:71:21: error: expected ';' at end of declaration list
        unsigned rd_base:32 __packed;   /* base address  */
                           ^
emaste requested changes to this revision.Oct 30 2023, 12:51 AM
This revision now requires changes to proceed.Oct 30 2023, 12:51 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Nov 29 2023, 5:16 PM
This revision was automatically updated to reflect the committed changes.