Paths

Table of Contentst

Differential D41381

syslogd: Pre-open null file descriptor
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 4:36 PM.

Tags

None

Referenced Files

	F103863398: D41381.diff
	Sat, Nov 30, 10:18 AM

	Unknown Object (File)
	Wed, Nov 27, 11:49 PM

	Unknown Object (File)
	Wed, Nov 27, 8:45 AM

	Unknown Object (File)
	Sat, Nov 16, 9:15 PM

	Unknown Object (File)
	Oct 21 2024, 5:27 AM

	Unknown Object (File)
	Oct 21 2024, 5:27 AM

	Unknown Object (File)
	Oct 21 2024, 5:27 AM

	Unknown Object (File)
	Oct 21 2024, 4:01 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG7428ebfe7e25: syslogd: Pre-open null file descriptor

Summary

Open _PATH_DEVNULL before entering capability mode. Access to /dev/null
is needed for dup2() when piping commands.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 4:36 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 4:36 PM

jfree requested review of this revision.Aug 8 2023, 4:36 PM

jfree added a parent revision: D41380: syslogd: Do not open console descriptor.

markj accepted this revision.Aug 11 2023, 3:06 PM

markj added inline comments.

usr.sbin/syslogd/syslogd.c
882	I think you could reasonably abort the process if /dev/null isn't accessible. Then you don't need those `nulldesc >= 0` checks.
3618–3619	There is a pre-existing buglet here in that pfd[0] and [1] are not closed if pdfork() fails.

This revision is now accepted and ready to land.Aug 11 2023, 3:06 PM

Update after rebase and address Mark's comments

This revision now requires review to proceed.Aug 12 2023, 3:50 AM

Remove some rebasing errors (consfile got declared twice)

jfree added a child revision: D41433: syslogd: Ignore signals in sigcatch[].Aug 12 2023, 4:03 AM

markj accepted this revision.Aug 14 2023, 2:26 PM

This revision is now accepted and ready to land.Aug 14 2023, 2:26 PM

The nulldesc descriptor is used in waitdaemon() so open it prior to calling waitdaemon()

This revision now requires review to proceed.Aug 14 2023, 5:52 PM

Update after peerlist rebase, adding pidfile_remove()

markj accepted this revision.Aug 23 2023, 2:39 PM

This revision is now accepted and ready to land.Aug 23 2023, 2:39 PM

Closed by commit rG7428ebfe7e25: syslogd: Pre-open null file descriptor (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:54 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG7428ebfe7e25: syslogd: Pre-open null file descriptor.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

27 lines

Diff 126279

usr.sbin/syslogd/syslogd.c

Loading...