Page MenuHomeFreeBSD
Differential D41376

syslogd: Fix sizeof() styling
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:40 PM.
Tags
None
Referenced Files
F108737239: D41376.id125888.diff
Mon, Jan 27, 3:26 PM
F108736722: D41376.id127958.diff
Mon, Jan 27, 3:21 PM
F108733520: D41376.id125846.diff
Mon, Jan 27, 2:54 PM
Unknown Object (File)
Mon, Jan 27, 12:33 AM
Unknown Object (File)
Sat, Jan 18, 9:26 PM
Unknown Object (File)
Sat, Jan 18, 9:16 PM
Unknown Object (File)
Sat, Jan 18, 5:51 AM
Unknown Object (File)
Fri, Jan 17, 3:07 PM
View All 71 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG09080d8ec52b: syslogd: Fix sizeof() styling
Summary

Use parentheses when applying sizeof() per style(9).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 3:40 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:40 PM
jfree requested review of this revision.Aug 8 2023, 3:40 PM
jfree added a parent revision: D41375: syslogd: Move action parsing into its own function.
emaste accepted this revision.Aug 8 2023, 3:43 PM

when calling sizeof()

We don't really "call" sizeof (why parens aren't needed) so perhaps "with sizeof()"

This revision is now accepted and ready to land.Aug 8 2023, 3:43 PM
jfree added a child revision: D41377: syslogd: Move struct definitions into header.Aug 8 2023, 4:32 PM
jfree edited the summary of this revision. (Show Details)Aug 8 2023, 4:40 PM
markj accepted this revision.Aug 9 2023, 7:12 PM
In D41376#942040, @emaste wrote:

when calling sizeof()

We don't really "call" sizeof (why parens aren't needed) so perhaps "with sizeof()"

Right, sizeof is an operator, so "when applying sizeof" would be more appropriate if you wanted to keep the original sentence structure.

jfree updated this revision to Diff 125846.Aug 10 2023, 11:14 PM
jfree edited the summary of this revision. (Show Details)

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:14 PM
jfree added a child revision: D41388: syslogd: Add closelogfiles() function.Aug 10 2023, 11:15 PM
markj accepted this revision.Aug 11 2023, 3:00 PM
This revision is now accepted and ready to land.Aug 11 2023, 3:00 PM
jfree removed a child revision: D41377: syslogd: Move struct definitions into header.Aug 11 2023, 3:22 PM
jfree updated this revision to Diff 125888.Aug 11 2023, 6:22 PM

Update to avoid rebase conflict

This revision now requires review to proceed.Aug 11 2023, 6:22 PM
markj accepted this revision.Aug 14 2023, 2:23 PM
This revision is now accepted and ready to land.Aug 14 2023, 2:23 PM
emaste accepted this revision.Aug 14 2023, 5:27 PM
Closed by commit rG09080d8ec52b: syslogd: Fix sizeof() styling (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:59 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG09080d8ec52b: syslogd: Fix sizeof() styling.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
16 lines

Diff 125888

View Options

usr.sbin/syslogd/syslogd.c

Loading...