ifconfig: Fix the display of capabilities in the netlink based code.
ClosedPublic
Actions

Authored by np on Jul 20 2023, 1:26 AM.

Details

Reviewers

kib
melifaro
jhb

Commits

rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code.

Summary

The capabilities in if_capabilities2/if_capenable2 that don't fit in the
first 32b were not being displayed correctly. v does not need to be
advanced because v[i / 32] is the correct uint32_t already.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52735
Build 49626: arc lint + arc unit

Event Timeline

np created this revision.Jul 20 2023, 1:26 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 20 2023, 1:26 AM

np requested review of this revision.Jul 20 2023, 1:26 AM

Harbormaster completed remote builds in B52735: Diff 124895.Jul 20 2023, 1:26 AM

I am experimenting with some additional caps that use bits in capabilities2/capenable2 and that's how I ran into this.

kib accepted this revision.Jul 20 2023, 9:44 AM

kib added inline comments.

sbin/ifconfig/ifconfig_netlink.c
90	btw i should have unsigned type, otherwise i<<31 is UB

This revision is now accepted and ready to land.Jul 20 2023, 9:44 AM

np added inline comments.Jul 20 2023, 5:27 PM

sbin/ifconfig/ifconfig_netlink.c
90	i is not shifted anywhere in this routine.

Closed by commit rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code. (authored by np). · Explain WhyJul 20 2023, 5:28 PM

This revision was automatically updated to reflect the committed changes.

np added a commit: rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code..

kib added inline comments.Jul 20 2023, 5:39 PM

sbin/ifconfig/ifconfig_netlink.c
90	Err, yes. the line above should use 1U instead of 1.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig_netlink.c

2 lines

Diff 124895

View Options

sbin/ifconfig/ifconfig_netlink.c

ifconfig: Fix the display of capabilities in the netlink based code.ClosedPublicActions