Page MenuHomeFreeBSD
Differential D40564

asa: Add some unit tests.
ClosedPublic
Actions

Authored by des on Jun 15 2023, 12:49 PM.
Tags
None
Referenced Files
F166505184: D40564.id123274.diff
Thu, Aug 13, 8:55 PM
F166453464: D40564.id123297.diff
Thu, Aug 13, 4:18 PM
Unknown Object (File)
Thu, Aug 13, 1:16 AM
Unknown Object (File)
Wed, Aug 12, 2:40 PM
Unknown Object (File)
Tue, Aug 11, 10:57 PM
Unknown Object (File)
Tue, Aug 11, 8:24 PM
Unknown Object (File)
Mon, Aug 10, 12:41 PM
Unknown Object (File)
Mon, Aug 10, 10:09 AM
View All Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rGb7412da2e122: asa: Add some unit tests.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52081
Build 48972: arc lint + arc unit

Event Timeline

des created this revision.Jun 15 2023, 12:49 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2023, 12:49 PM
des requested review of this revision.Jun 15 2023, 12:49 PM
Harbormaster completed remote builds in B52081: Diff 123274.Jun 15 2023, 12:49 PM
des added a parent revision: D40563: asa: Read from stdin if *argv is "-"..Jun 15 2023, 12:49 PM
markj accepted this revision as: markj.Jun 15 2023, 3:08 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/asa/tests/asa_test.sh
86

Presumably this should be -s not-exit:0. -s not-exit just checks that the program didn't exit due to a signal.

This revision is now accepted and ready to land.Jun 15 2023, 3:08 PM
des marked an inline comment as done.Jun 15 2023, 7:14 PM
des added inline comments.
usr.bin/asa/tests/asa_test.sh
86

Thank you, will fix before committing.

Closed by commit rGb7412da2e122: asa: Add some unit tests. (authored by des). · Explain WhyJun 15 2023, 7:28 PM
This revision was automatically updated to reflect the committed changes.
des marked an inline comment as done.
des added a commit: rGb7412da2e122: asa: Add some unit tests..
des mentioned this in rG77d9e708c07b: asa: Error out if writing to stdout failed..Jul 3 2023, 3:15 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
asa/
5 lines
tests/
4 lines
99 lines

Diff 123274

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/asa/Makefile

Loading...
View Options

usr.bin/asa/tests/Makefile

Loading...
View Options

usr.bin/asa/tests/asa_test.sh

Loading...