Page MenuHomeFreeBSD
Differential D40438

ifconfig: remove global 'name' variable.
ClosedPublic
Actions

Authored by melifaro on Jun 6 2023, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 12:17 AM
Unknown Object (File)
Sun, Mar 22, 8:07 AM
Unknown Object (File)
Sun, Mar 22, 8:07 AM
Unknown Object (File)
Fri, Mar 20, 5:54 AM
Unknown Object (File)
Fri, Mar 20, 4:26 AM
Unknown Object (File)
Fri, Mar 20, 4:26 AM
Unknown Object (File)
Fri, Mar 20, 4:26 AM
Unknown Object (File)
Thu, Mar 19, 8:42 AM
View All Files
Subscribers
imp

Details

Reviewers
kp
bz
Group Reviewers
network
Commits
rG85e0016a9730: ifconfig: remove global 'name' variable.
Summary

Consistenly use newly-added 'ctx->ifname' as the name of the current
target interface.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51927
Build 48818: arc lint + arc unit

Event Timeline

melifaro created this revision.Jun 6 2023, 12:49 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 6 2023, 12:49 PM
melifaro requested review of this revision.Jun 6 2023, 12:49 PM
Harbormaster completed remote builds in B51925: Diff 122889.Jun 6 2023, 12:49 PM
melifaro added reviewers: network, kp, bz.Jun 6 2023, 12:51 PM
melifaro added a parent revision: D40432: ifconfig: pass if_ctx instead of socket to the tunnel handlers..
melifaro updated this revision to Diff 122890.Jun 6 2023, 12:55 PM

Fix build w/o Netlink.

Harbormaster completed remote builds in B51926: Diff 122890.Jun 6 2023, 12:55 PM
melifaro updated this revision to Diff 122891.Jun 6 2023, 1:01 PM

remove 'extern name[]'

Harbormaster completed remote builds in B51927: Diff 122891.Jun 6 2023, 1:02 PM
melifaro added a child revision: D40439: ifconfig: remove global_args.Jun 6 2023, 1:03 PM
kp accepted this revision as: kp.Jun 6 2023, 5:24 PM
This revision is now accepted and ready to land.Jun 6 2023, 5:24 PM
Closed by commit rG85e0016a9730: ifconfig: remove global 'name' variable. (authored by melifaro). · Explain WhyJun 13 2023, 6:28 AM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG85e0016a9730: ifconfig: remove global 'name' variable..

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
8 lines
8 lines
8 lines
100 lines
4 lines
9 lines
76 lines
24 lines
8 lines
4 lines
14 lines
644 lines
2 lines
33 lines
4 lines
32 lines
8 lines

Diff 122891

View Options

sbin/ifconfig/af_inet.c

Loading...
View Options

sbin/ifconfig/af_inet6.c

Loading...
View Options

sbin/ifconfig/carp.c

Loading...
View Options

sbin/ifconfig/ifbridge.c

Loading...
View Options

sbin/ifconfig/ifclone.c

Loading...
View Options

sbin/ifconfig/ifconfig.h

Loading...
View Options

sbin/ifconfig/ifconfig.c

Loading...
View Options

sbin/ifconfig/ifconfig_netlink.c

Loading...
View Options

sbin/ifconfig/iffib.c

Loading...
View Options

sbin/ifconfig/ifgre.c

Loading...
View Options

sbin/ifconfig/ifgroup.c

Loading...
View Options

sbin/ifconfig/ifieee80211.c

Loading...
View Options

sbin/ifconfig/ifipsec.c

Loading...
View Options

sbin/ifconfig/iflagg.c

Loading...
View Options

sbin/ifconfig/ifmac.c

Loading...
View Options

sbin/ifconfig/ifmedia.c

Loading...
View Options

sbin/ifconfig/sfp.c

Loading...